fix: An extra space is created at the top of the chat list when pin and unpin #38656

dukenv0307 · 2024-03-20T02:52:23Z

Details

Fixed Issues

$ #37497
PROPOSAL: #37497 (comment)

Tests

Start a conversation between two accounts, account A (main testing device) account B on another device
Send an IOU from account B to account A (to the main testing device)
Pay the IOU from account A (on android)
Go to the LHN and unpin any other conversation you have and let the conversation you had with account B be at the top
Hold on the chat with account B and pin it
Hold on the chat with account B again and unpin it right away
Verify that: There should be no extra space between the top chat and the title on the LHN

Verify that no errors appear in the JS console

Offline tests

QA Steps

Start a conversation between two accounts, account A (main testing device) account B on another device
Send an IOU from account B to account A (to the main testing device)
Pay the IOU from account A (on android)
Go to the LHN and unpin any other conversation you have and let the conversation you had with account B be at the top
Hold on the chat with account B and pin it
Hold on the chat with account B again and unpin it right away
Verify that: There should be no extra space between the top chat and the title on the LHN

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-resize.mp4

Android: mWeb Chrome

ios-mweb.mov

iOS: Native

Screen.Recording.2024-03-20.at.14.30.01.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-20.at.14.16.00.mov

MacOS: Desktop

Screen.Recording.2024-03-20.at.14.16.31.mov

…ng and unpinning

melvin-bot · 2024-03-20T07:44:09Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif

Code looks good, though it's weird to have some duplicated logic in different places.

aimane-chnaif · 2024-03-21T00:53:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

aimane-chnaif

@Julesssss all yours

OSBotify · 2024-03-21T09:50:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

shubham1206agra · 2024-03-21T10:52:56Z

src/libs/SidebarUtils.ts

@@ -79,9 +79,19 @@ function getOrderedReportIDs(
    let reportsToDisplay = allReportsDictValues.filter((report) => {
        const parentReportActionsKey = `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.parentReportID}`;
        const parentReportActions = allReportActions?.[parentReportActionsKey];
+        const reportActions = ReportActionsUtils.getAllReportActions(report.reportID);


@Julesssss This line is creating a crash for me.
The correct line should be

const reportActions = ReportActionsUtils.getAllReportActions(report?.reportID);

@dukenv0307 Would you create a new PR, and I will review this as @aimane-chnaif is OOO.

Interesting. When's the case of report being nullish? Maybe you have bad Onyx data?
I prefer early return false if (!report)

Umm. The problem is that the type of this function is not correct right now. I corrected it in another PR, but that got unfortunately reverted due to a performance issue.

A small refactor: #38741

Nice, so I think we'd just need to run the test from here to confirm.

shubham1206agra · 2024-03-21T11:03:43Z

@mountiny Can you profile this PR for performance? The code is very similar to what I wrote in #35907.
cc @youssef-lr

OSBotify · 2024-03-22T16:22:21Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-27T04:51:30Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 2 commits March 19, 2024 22:46

fix: An extra space is created at the top of the chat list when pinni…

b235777

…ng and unpinning

remove useless code

b16cef4

dukenv0307 changed the title ~~fix: An extra space is created at the top of the chat list when pinni…~~ fix: An extra space is created at the top of the chat list when pinni Mar 20, 2024

dukenv0307 changed the title ~~fix: An extra space is created at the top of the chat list when pinni~~ fix: An extra space is created at the top of the chat list when pin and unpin Mar 20, 2024

dukenv0307 marked this pull request as ready for review March 20, 2024 07:44

dukenv0307 requested a review from a team as a code owner March 20, 2024 07:44

melvin-bot bot removed the request for review from a team March 20, 2024 07:44

melvin-bot bot requested a review from aimane-chnaif March 20, 2024 07:44

aimane-chnaif reviewed Mar 21, 2024

View reviewed changes

aimane-chnaif approved these changes Mar 21, 2024

View reviewed changes

Julesssss approved these changes Mar 21, 2024

View reviewed changes

Julesssss merged commit 51ef6c1 into Expensify:main Mar 21, 2024
22 of 23 checks passed

shubham1206agra reviewed Mar 21, 2024

View reviewed changes

aimane-chnaif mentioned this pull request Mar 21, 2024

[No QA] fix crash on sidebarutils #38741

Merged

50 tasks

DylanDylann mentioned this pull request Mar 22, 2024

[$500] Scan - Expense report and transaction report are no longer hidden in LHN when scanning fails #37296

Closed

6 tasks

github-actions bot mentioned this pull request Mar 22, 2024

Deploy Checklist: New Expensify 2024-03-22 #38811

Closed

aimane-chnaif mentioned this pull request May 22, 2024

[$500] Android - An extra space is created at the top of the chat list when pinning and unpinning #37497

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: An extra space is created at the top of the chat list when pin and unpin #38656

fix: An extra space is created at the top of the chat list when pin and unpin #38656

dukenv0307 commented Mar 20, 2024 •

edited

Loading

melvin-bot bot commented Mar 20, 2024

aimane-chnaif left a comment

aimane-chnaif commented Mar 21, 2024

aimane-chnaif left a comment

OSBotify commented Mar 21, 2024

shubham1206agra Mar 21, 2024

shubham1206agra Mar 21, 2024

aimane-chnaif Mar 21, 2024

shubham1206agra Mar 21, 2024

aimane-chnaif Mar 21, 2024

Julesssss Mar 21, 2024

shubham1206agra commented Mar 21, 2024 •

edited

Loading

OSBotify commented Mar 22, 2024

OSBotify commented Mar 27, 2024

fix: An extra space is created at the top of the chat list when pin and unpin #38656

fix: An extra space is created at the top of the chat list when pin and unpin #38656

Conversation

dukenv0307 commented Mar 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 20, 2024

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif commented Mar 21, 2024

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 21, 2024

shubham1206agra Mar 21, 2024

Choose a reason for hiding this comment

shubham1206agra Mar 21, 2024

Choose a reason for hiding this comment

aimane-chnaif Mar 21, 2024

Choose a reason for hiding this comment

shubham1206agra Mar 21, 2024

Choose a reason for hiding this comment

aimane-chnaif Mar 21, 2024

Choose a reason for hiding this comment

Julesssss Mar 21, 2024

Choose a reason for hiding this comment

shubham1206agra commented Mar 21, 2024 • edited Loading

OSBotify commented Mar 22, 2024

OSBotify commented Mar 27, 2024

dukenv0307 commented Mar 20, 2024 •

edited

Loading

shubham1206agra commented Mar 21, 2024 •

edited

Loading