Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed manifest for Firefox, added linting and CI #198

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

mjasikowski
Copy link
Contributor

@mjasikowski mjasikowski commented Oct 3, 2024

Fixed problems with the FF extension by using the web-ext package from Mozilla, which helps with linting.
Web-ext linting was also added as a step to GitHub actions, so we can be sure it's compatible with Firefox without having to first package and upload to addons.mozilla.org.

@mjasikowski mjasikowski marked this pull request as ready for review October 3, 2024 08:37
@mjasikowski mjasikowski requested review from tgolen, dangrous and a team October 3, 2024 08:37
@mjasikowski mjasikowski self-assigned this Oct 3, 2024
@melvin-bot melvin-bot bot requested review from nkuoch and removed request for a team October 3, 2024 08:38
@mjasikowski
Copy link
Contributor Author

Not sure while snyk licensing is failing (the only package added was web-ext which has MPL 2.0) - I don't have access to Expensify's Snyk org.

@francoisl
Copy link

I sent you an invite to Snyk. In the meantime, we can manually mark the check as succsesful in Snyk, which I just did.

tgolen
tgolen previously approved these changes Oct 7, 2024
dangrous
dangrous previously approved these changes Oct 7, 2024
@mjasikowski mjasikowski dismissed stale reviews from dangrous and tgolen October 7, 2024 17:35

The merge-base changed after approval.

tgolen
tgolen previously approved these changes Oct 7, 2024
@mjasikowski mjasikowski dismissed tgolen’s stale review October 7, 2024 20:50

The merge-base changed after approval.

tgolen
tgolen previously approved these changes Oct 8, 2024
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to approve again.

@mjasikowski mjasikowski dismissed tgolen’s stale review October 8, 2024 15:22

The merge-base changed after approval.

@tgolen
Copy link
Contributor

tgolen commented Oct 8, 2024

Still getting auto-rejected :(

dangrous
dangrous previously approved these changes Oct 8, 2024
@mjasikowski mjasikowski dismissed dangrous’s stale review October 8, 2024 16:19

The merge-base changed after approval.

@dangrous
Copy link
Contributor

dangrous commented Oct 8, 2024

dang, thought i'd be lucky haha

@mjasikowski
Copy link
Contributor Author

Waiting for GitHub to get back to me on the support ticket

@mjasikowski mjasikowski closed this Oct 8, 2024
@mjasikowski mjasikowski reopened this Oct 8, 2024
@mjasikowski
Copy link
Contributor Author

@dangrous @tgolen it's fixed now, closing and reopening PRs works

@dangrous
Copy link
Contributor

dangrous commented Oct 8, 2024

wooo

@tgolen tgolen merged commit e9dbce1 into main Oct 8, 2024
3 checks passed
@tgolen tgolen deleted the michal-firefox branch October 8, 2024 19:42
@tgolen
Copy link
Contributor

tgolen commented Oct 8, 2024

Yay, that worked. I'm publishing it now and then you can send out an email to everyone announcing the new version once I give you the green light.

@tgolen
Copy link
Contributor

tgolen commented Oct 8, 2024

OK, green light! I've uploaded it to 1Password.

Send an email to @ALL to let anyone know they can update by following the steps from I use firefox, how do I install the Kernel Scheduler (KS) browser extension?

@tgolen
Copy link
Contributor

tgolen commented Oct 8, 2024

Here is an example email I sent out a while ago:

image

@mjasikowski
Copy link
Contributor Author

@tgolen I'll go through the remaining snyk PRs, bump the version number and then deal with the e-mail - at least we'll have a "security updates" changelog entry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants