Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed manifest for Firefox, added linting and CI #198

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fixed manifest for Firefox, added linting and CI #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
373875b
Added linting for Firefox in GH actions
mjasikowski Oct 3, 2024
88fd9f6
Bumped versions
mjasikowski Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: 0

- uses: actions/cache@v2
- name: Add build cache
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
Expand All @@ -31,4 +33,8 @@ jobs:
max_attempts: 5
command: npm ci

- run: npx eslint --max-warnings=0 $(git diff --diff-filter=ACM --name-only origin/main '**/*.js' | xargs)
- name: Lint with ESLint
run: npx eslint --max-warnings=0 $(git diff --diff-filter=ACM --name-only origin/main '**/*.js' | xargs)
- name: Lint for Firefox
run: npm run lint:firefox

3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#1.3.67
- Added additional linting and CI for Firefox

#1.3.66
- Added Firefox build script for Manifest V3 compatibility

Expand Down
8 changes: 4 additions & 4 deletions assets/manifest-firefox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
"manifest_version": 3,

"name": "K2 for GitHub",
"version": "1.3.66",
"version": "1.3.67",
"description": "Manage your Kernel Scheduling from directly inside GitHub",

"browser_specific_settings": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "48.0"
"gecko": {
"id": "[email protected]",
"strict_min_version": "112.0"
}
},

Expand Down
9 changes: 1 addition & 8 deletions assets/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,9 @@
"manifest_version": 3,

"name": "K2 for GitHub",
"version": "1.3.66",
"version": "1.3.67",
"description": "Manage your Kernel Scheduling from directly inside GitHub",

"browser_specific_settings": {
"gecko": {
"id": "[email protected]",
"strict_min_version": "42.0"
}
},

"icons": {
"16": "icon16.png",
"48": "icon48.png",
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "k2-extension",
"version": "1.3.66",
"version": "1.3.67",
"description": "A Chrome Extension for Kernel Schedule",
"private": true,
"scripts": {
Expand Down
Loading