Disable TPS error check on autocal #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mck1117
reviewed
Nov 13, 2024
| @@ -532,7 +532,8 @@ bool EtbController::checkStatus() { | |||
|
|
|||
| bool shouldCheckSensorFunction = engine->module<SensorChecker>()->analogSensorsShouldWork(); | |||
|
|
|||
| if (!m_isAutotune && shouldCheckSensorFunction) { | |||
| if (!m_isAutotune && shouldCheckSensorFunction && !m_isAutocal) { | |||
| // Added check to remove TPS errors during autocalibration https://github.com/FOME-Tech/fome-fw/issues/504 | |||
There was a problem hiding this comment.
you can just do #504 instead of the full link, we know what repo it's for 🙂
There was a problem hiding this comment.
On second thought...I don't think this change actually does anything. Look at the implementation of auto calibrate around lines 650-710. It blocks normal operation (including tps validation) of the throttle while doing the calibration routine, and directly takes control of the motor.
|
this doesn't help, bug is completely different as discussed on discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#504