Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TPS error check on autocal #511

Closed
wants to merge 1 commit into from
Closed

Disable TPS error check on autocal #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion firmware/controllers/actuators/electronic_throttle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,8 @@ bool EtbController::checkStatus() {

bool shouldCheckSensorFunction = engine->module<SensorChecker>()->analogSensorsShouldWork();

if (!m_isAutotune && shouldCheckSensorFunction) {
if (!m_isAutotune && shouldCheckSensorFunction && !m_isAutocal) {
// Added check to remove TPS errors during autocalibration https://github.com/FOME-Tech/fome-fw/issues/504
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just do #504 instead of the full link, we know what repo it's for 🙂

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought...I don't think this change actually does anything. Look at the implementation of auto calibrate around lines 650-710. It blocks normal operation (including tps validation) of the throttle while doing the calibration routine, and directly takes control of the motor.

bool isTpsError = !Sensor::get(m_positionSensor).Valid;

// If we have an error that's new, increment the counter
Expand Down
Loading