Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Menu Bar to Tesseratos #1235

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Jun 5, 2024

Description

Adds a menu bar plugin to Tesseratos. This plugin basically picks up all entities with the MenuBarItem component, and shows them in the menu bar.

image

Additionally, ChildOf hierarchies lead to having drop-down menus within the bar.

image

Check out the editor main.cpp for an example of how these entities can be created.
Down the road, we should change plugins to add their own entries there.

User interaction is handled through observers: if the user selects an item in the menu, the MenuBarSelected component is added and immediately removed. This triggers any .onAdd<MenuBarSelected> observers added by users.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@RiscadoA RiscadoA added this to the 0.3 Standalone Editor milestone Jun 5, 2024
@RiscadoA RiscadoA self-assigned this Jun 5, 2024
@RiscadoA RiscadoA linked an issue Jun 5, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1235/
on branch gh-pages at 2024-07-22 08:33 UTC

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.27%. Comparing base (071ab63) to head (bcea446).
Report is 83 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   36.27%   36.27%           
=======================================
  Files         376      376           
  Lines       30851    30851           
=======================================
+ Hits        11191    11192    +1     
+ Misses      19660    19659    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 1234-add-a-menu-bar-to-tesseratos branch 2 times, most recently from 9756791 to 13a4bd3 Compare July 22, 2024 08:32
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

tools/tesseratos/src/tesseratos/menu_bar/plugin.cpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA marked this pull request as ready for review July 22, 2024 08:34
@RiscadoA RiscadoA requested a review from a team as a code owner July 22, 2024 08:34
@RiscadoA RiscadoA force-pushed the 1234-add-a-menu-bar-to-tesseratos branch from 13a4bd3 to bcea446 Compare July 22, 2024 08:35
@RiscadoA RiscadoA marked this pull request as draft July 24, 2024 10:34
@RiscadoA RiscadoA modified the milestones: 0.3, 0.4 - ??? Aug 2, 2024
@RiscadoA RiscadoA removed this from the 0.4 milestone Sep 22, 2024
@RiscadoA RiscadoA added the S-Stale Has been abandoned, but kept for reference label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tesseratos B-Tools S-Stale Has been abandoned, but kept for reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a menu bar to Tesseratos which replaces the Toolbox
4 participants