Fix non-deterministic ECS stress test failures #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
==========================================
+ Coverage 54.22% 54.36% +0.13%
==========================================
Files 438 438
Lines 25341 25376 +35
Branches 2347 2346 -1
==========================================
+ Hits 13741 13795 +54
+ Misses 11600 11581 -19 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
RiscadoA
force-pushed
the
1363-ecs-stress-test-fails-non-deterministically
branch
3 times, most recently
from
413a5e9 to
6a68ec3
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
RiscadoA
force-pushed
the
1363-ecs-stress-test-fails-non-deterministically
branch
from
6a68ec3 to
e13e362
Compare
RiscadoA
requested review from
Dageus and
SrGesus
and removed request for
a team
SrGesus
approved these changes
Nov 18, 2024
RiscadoA
requested review from
a team and
diogomsmiranda
and removed request for
a team
diogomsmiranda
approved these changes
Nov 21, 2024
Previously the behavior queries had with symmetric relations on entities was not consistent. For example, if we had a symmetric relation R, and an entity 0, with a relation from 0 to 0, then, when querying over relation R, we would get (0, 0) twice! This only happened when the query was asymmetric, i.e, when the requirements on both targets were different. If they were the same, we would only get (0, 0). This lead to some inconsistencies between the tests and the query code. I also think it was a bit confusing, so I changed it to always return only one match in these cases.
This was causing undefined behavior, as within the table iteration loop, new tables could be created with calls to propagateDepth
RiscadoA
force-pushed
the
1363-ecs-stress-test-fails-non-deterministically
branch
from
e13e362 to
4265115
Compare
RiscadoA
deleted the
1363-ecs-stress-test-fails-non-deterministically
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made two fixes on this PR. I added long explanations to the commit messages, if you're curious.
Checklist