-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed delta time not used in some physics systems #1372
fix: Fixed delta time not used in some physics systems #1372
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1372 +/- ##
=======================================
Coverage 53.74% 53.75%
=======================================
Files 449 449
Lines 25666 25668 +2
Branches 2374 2374
=======================================
+ Hits 13795 13797 +2
Misses 11871 11871 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Don't forget to also cover what @fallenatlas talked about in Discord.
Also, add a CHANGELOG entry!
37b1771
to
9abdf3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Btw please change the commit msg before merging to something like |
9abdf3d
to
30b0022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Include a summary of the changes here.
Checklist