Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed delta time not used in some physics systems #1372

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

joaomanita
Copy link
Contributor

Description

Include a summary of the changes here.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@joaomanita joaomanita requested a review from a team November 19, 2024 19:35
@joaomanita joaomanita self-assigned this Nov 19, 2024
@joaomanita joaomanita requested review from fallenatlas and GCeSilva and removed request for a team November 19, 2024 19:35
@joaomanita joaomanita requested review from RiscadoA and a team as code owners November 19, 2024 19:35
@joaomanita joaomanita requested review from Dageus and removed request for a team November 19, 2024 19:35
@joaomanita joaomanita linked an issue Nov 19, 2024 that may be closed by this pull request
@github-actions github-actions bot added A-Engine B-Physics S-Triage Issues whose priority still has to be figured out labels Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1372/
on branch gh-pages at 2024-11-26 20:29 UTC

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.75%. Comparing base (49e590f) to head (ea9e4f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/physics/plugin.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1372   +/-   ##
=======================================
  Coverage   53.74%   53.75%           
=======================================
  Files         449      449           
  Lines       25666    25668    +2     
  Branches     2374     2374           
=======================================
+ Hits        13795    13797    +2     
  Misses      11871    11871           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Don't forget to also cover what @fallenatlas talked about in Discord.
Also, add a CHANGELOG entry!

@joaomanita joaomanita force-pushed the 1361-fixed-delta-time-potentially-not-working-right branch from 37b1771 to 9abdf3d Compare November 22, 2024 08:54
Copy link
Contributor

@Dageus Dageus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@RiscadoA
Copy link
Member

Btw please change the commit msg before merging to something like fix(physics): do fixed updates correctly

@RiscadoA RiscadoA added this to the 0.5 milestone Nov 23, 2024
@joaomanita joaomanita force-pushed the 1361-fixed-delta-time-potentially-not-working-right branch from 9abdf3d to 30b0022 Compare November 23, 2024 18:21
Copy link
Contributor

@fallenatlas fallenatlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@GCeSilva GCeSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@joaomanita joaomanita merged commit fba21ee into main Nov 26, 2024
11 checks passed
@joaomanita joaomanita deleted the 1361-fixed-delta-time-potentially-not-working-right branch November 26, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Engine B-Physics S-Triage Issues whose priority still has to be figured out
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed Delta Time potentially not working right
5 participants