-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(audio): add audioPlugin and audio sample #1383
Conversation
|
d3ab458
to
6fa4a18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
6fa4a18
to
044b775
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
- Coverage 53.39% 53.04% -0.35%
==========================================
Files 451 460 +9
Lines 25844 26014 +170
Branches 2390 2411 +21
==========================================
Hits 13800 13800
- Misses 12044 12214 +170 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
c632fe1
to
d05104f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
b5692ac
to
56439f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (2/2)
d5018ed
to
6ece7c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
3fd3e5e
to
b10a017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's not much to point out since I also worked on this, lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good overall! 🚀
The only thing that I'd point out, it's what has already been discussed about the physics plugin to get velocity, etc, so it's fine for now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty very much for working on this! Feel free to merge after resolving my comments.
Make sure to take the time to open follow up issues on work that can be done to improve what this PR adds, or stuff that's missing.
Also, the issues you linked to be closed were not detected by GitHub automatically, you'll have to link them manually.
d48f9dc
to
d7c63fc
Compare
d7c63fc
to
659eb2f
Compare
Co-Authored-By: João Miguel Nogueira <[email protected]>
659eb2f
to
39c8d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
39c8d7c
to
2fd7e02
Compare
Co-Authored-By: João Miguel Nogueira <[email protected]>
Co-Authored-By: João Miguel Nogueira <[email protected]>
2fd7e02
to
0e8a268
Compare
Description
Adds audioPlugin, this finally adds audio to CUBOS. You can manage entities now with the new components
AudioListener
andAudioSource
.You can play, stop and pause sounds by adding the components,
AudioPlay
,AudioPause
,AudioStop
, to theAudioSource
's entity.closes #1004 #1317 #1318 #231 #1041 #1042
What's Missing
A more extensive sample?
Core Tests / Engine Tests?
Checklist