Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anti-aliasing): add anti-aliasing by FXAA #1385

Merged
merged 1 commit into from
Nov 29, 2024
Merged

feat(anti-aliasing): add anti-aliasing by FXAA #1385

merged 1 commit into from
Nov 29, 2024

Conversation

kuukitenshi
Copy link
Contributor

Add anti-aliasing by FXAA

Added anti-aliasing using the FXAA technique.

Before
image

After
image

Checklist

  • Self-review changes.
  • Add entry to the changelog's unreleased section.

@kuukitenshi kuukitenshi requested review from RiscadoA, tomas7770 and a team as code owners November 23, 2024 22:38
@kuukitenshi kuukitenshi linked an issue Nov 23, 2024 that may be closed by this pull request
Add Anti-Aliasing #1334
Closed
@kuukitenshi kuukitenshi requested review from Docas95 and SrGesus and removed request for a team November 23, 2024 22:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 23, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1385/
on branch gh-pages at 2024-11-29 01:38 UTC

@kuukitenshi kuukitenshi added this to the 0.5 milestone Nov 23, 2024
@kuukitenshi kuukitenshi self-assigned this Nov 23, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 53.70%. Comparing base (fba21ee) to head (f6fe55c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/render/tone_mapping/plugin.cpp 0.00% 18 Missing ⚠️
engine/src/render/tone_mapping/fxaa.cpp 0.00% 7 Missing ⚠️
engine/src/render/defaults/plugin.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
- Coverage   53.75%   53.70%   -0.06%     
==========================================
  Files         449      450       +1     
  Lines       25668    25691      +23     
  Branches     2374     2375       +1     
==========================================
- Hits        13798    13797       -1     
- Misses      11870    11894      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SrGesus SrGesus removed their request for review November 23, 2024 23:11
RiscadoA
RiscadoA approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tyvm for working on this! Always cool to see graphics improvements 👀
LGTM, I just added some suggestions which I think would be nice to have and make this more flexible.

engine/assets/render/tone_mapping.fs Outdated Show resolved Hide resolved
@kuukitenshi kuukitenshi force-pushed the 1334-add-anti-aliasing branch 3 times, most recently from 1c64209 to 5405b3a Compare November 25, 2024 22:19
tomas7770
tomas7770 reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@tomas7770 tomas7770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! I left some more comments about potential things to improve/fix.

engine/include/cubos/engine/render/tone_mapping/fxaa.hpp Outdated Show resolved Hide resolved
engine/src/render/tone_mapping/plugin.cpp Outdated Show resolved Hide resolved
engine/src/render/tone_mapping/plugin.cpp Outdated Show resolved Hide resolved
engine/assets/render/tone_mapping.fs Outdated Show resolved Hide resolved
engine/src/render/tone_mapping/plugin.cpp Outdated Show resolved Hide resolved
engine/src/render/tone_mapping/plugin.cpp Show resolved Hide resolved
@kuukitenshi kuukitenshi force-pushed the 1334-add-anti-aliasing branch from 5405b3a to 43b6e5f Compare November 28, 2024 01:40
tomas7770
tomas7770 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@tomas7770 tomas7770 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one final detail you forgot 😌

engine/src/render/tone_mapping/plugin.cpp Outdated Show resolved Hide resolved
@kuukitenshi kuukitenshi force-pushed the 1334-add-anti-aliasing branch from 43b6e5f to 6e31cd1 Compare November 28, 2024 11:53
@kuukitenshi kuukitenshi force-pushed the 1334-add-anti-aliasing branch from 6e31cd1 to 9f33a4f Compare November 29, 2024 01:37
github-actions[bot]
github-actions bot reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/src/render/tone_mapping/plugin.cpp Outdated Show resolved Hide resolved
@kuukitenshi kuukitenshi force-pushed the 1334-add-anti-aliasing branch from 9f33a4f to f6fe55c Compare November 29, 2024 08:10
@kuukitenshi kuukitenshi merged commit 6508bfc into main Nov 29, 2024
11 checks passed
@kuukitenshi kuukitenshi deleted the 1334-add-anti-aliasing branch November 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tomas7770 tomas7770 tomas7770 approved these changes

@Docas95 Docas95 Docas95 approved these changes

@RiscadoA RiscadoA RiscadoA approved these changes

Assignees

@kuukitenshi kuukitenshi

Labels
A-Engine B-Rendering
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Add Anti-Aliasing
4 participants
@kuukitenshi @RiscadoA @Docas95 @tomas7770