-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move old serialization code to the namespace old::data
#437
Closed
RiscadoA
wants to merge
21
commits into
main
from
436-move-old-serialization-code-to-cuboscoreolddata-namespace
Closed
Move old serialization code to the namespace old::data
#437
RiscadoA
wants to merge
21
commits into
main
from
436-move-old-serialization-code-to-cuboscoreolddata-namespace
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
+ Coverage 24.55% 28.01% +3.45%
==========================================
Files 86 106 +20
Lines 7005 7461 +456
==========================================
+ Hits 1720 2090 +370
- Misses 5285 5371 +86
☔ View full report in Codecov by Sentry. |
RiscadoA
force-pushed
the
436-move-old-serialization-code-to-cuboscoreolddata-namespace
branch
from
June 29, 2023 15:50
8e4aeb5
to
bca3566
Compare
RiscadoA
added
A-Core
C-Code-Quality
A section of code that is hard to understand or change
labels
Aug 28, 2023
RiscadoA
deleted the
436-move-old-serialization-code-to-cuboscoreolddata-namespace
branch
September 28, 2023 21:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated this from the new serialization PR so that it doesn't get too cluttered.
This will be useful to tell which parts of the code need to be refactored later on.