Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move old serialization code to the namespace old::data #437

Conversation

RiscadoA
Copy link
Member

Separated this from the new serialization PR so that it doesn't get too cluttered.
This will be useful to tell which parts of the code need to be refactored later on.

@RiscadoA RiscadoA linked an issue Jun 24, 2023 that may be closed by this pull request
@RiscadoA RiscadoA self-assigned this Jun 24, 2023
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Patch coverage: 74.49% and project coverage change: +3.45 🎉

Comparison is base (d1169a0) 24.55% compared to head (bca3566) 28.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   24.55%   28.01%   +3.45%     
==========================================
  Files          86      106      +20     
  Lines        7005     7461     +456     
==========================================
+ Hits         1720     2090     +370     
- Misses       5285     5371      +86     
Impacted Files Coverage Δ
core/include/cubos/core/data/binary_serializer.hpp 100.00% <ø> (ø)
core/include/cubos/core/data/context.hpp 100.00% <ø> (ø)
core/include/cubos/core/data/debug_serializer.hpp 0.00% <ø> (ø)
core/include/cubos/core/data/deserializer.hpp 22.72% <ø> (ø)
core/include/cubos/core/data/package.hpp 80.00% <ø> (ø)
core/include/cubos/core/data/serialization_map.hpp 69.23% <ø> (ø)
core/include/cubos/core/data/serializer.hpp 25.00% <ø> (ø)
core/include/cubos/core/ecs/commands.hpp 95.65% <ø> (ø)
core/include/cubos/core/ecs/component_manager.hpp 100.00% <ø> (ø)
core/include/cubos/core/ecs/world.hpp 88.88% <ø> (ø)
... and 53 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RiscadoA RiscadoA force-pushed the 436-move-old-serialization-code-to-cuboscoreolddata-namespace branch from 8e4aeb5 to bca3566 Compare June 29, 2023 15:50
@RiscadoA RiscadoA added A-Core C-Code-Quality A section of code that is hard to understand or change labels Aug 28, 2023
@RiscadoA RiscadoA closed this Sep 9, 2023
@RiscadoA RiscadoA deleted the 436-move-old-serialization-code-to-cuboscoreolddata-namespace branch September 28, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant