Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and document engine-sample.assets #508

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Cleanup and document engine-sample.assets #508

merged 5 commits into from
Sep 25, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Sep 10, 2023 •
edited
Loading

Description

  • Removed the asset creation/saving code from the assets.json sample, moved it to a new assets.saving sample.
  • Wrote documentation for all three asset samples.

Checklist

  • Self-review changes.

@RiscadoA RiscadoA added this to the 0.0 Nursery milestone Sep 10, 2023
@RiscadoA RiscadoA self-assigned this Sep 10, 2023
@RiscadoA RiscadoA linked an issue Sep 10, 2023 that may be closed by this pull request
Cleanup and document engine-sample.assets #468
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-25 11:06 UTC

@codecov
Copy link

codecov bot commented Sep 10, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (3948aad) 25.55% compared to head (1f82da6) 25.55%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   25.55%   25.55%           
=======================================
  Files          93       93           
  Lines        7173     7173           
=======================================
  Hits         1833     1833           
  Misses       5340     5340

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 468-cleanup-and-document-engine-sampleassets branch from 0c1c436 to bfeb9c1 Compare September 13, 2023 20:06
@RiscadoA RiscadoA mentioned this pull request Sep 17, 2023
Merged
2 tasks
@RiscadoA RiscadoA requested review from DiogoMendonc-a and luishfonseca and removed request for luishfonseca September 19, 2023 22:37
@RiscadoA RiscadoA force-pushed the 468-cleanup-and-document-engine-sampleassets branch from bfeb9c1 to 9ddb25a Compare September 25, 2023 10:20
@RiscadoA RiscadoA force-pushed the 468-cleanup-and-document-engine-sampleassets branch from 9ddb25a to f4fdb46 Compare September 25, 2023 10:36
@RiscadoA RiscadoA force-pushed the 468-cleanup-and-document-engine-sampleassets branch from f4fdb46 to 1f82da6 Compare September 25, 2023 10:37
@RiscadoA RiscadoA merged commit 1359140 into main Sep 25, 2023
7 checks passed
@RiscadoA RiscadoA deleted the 468-cleanup-and-document-engine-sampleassets branch September 25, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luishfonseca luishfonseca luishfonseca approved these changes

Assignees

@RiscadoA RiscadoA

Labels
A-Engine B-Assets C-Documentation C-Examples
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging this pull request may close these issues.

Cleanup and document engine-sample.assets
2 participants
@RiscadoA @luishfonseca