Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ArrayTrait #546

Merged
merged 14 commits into from
Sep 28, 2023
Merged

Add ArrayTrait #546

merged 14 commits into from
Sep 28, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Sep 16, 2023 •
edited
Loading

Description

Adds the ArrayTrait and defines reflection for std::vector<T> types.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@RiscadoA RiscadoA added A-Core B-Reflection S-Blocked Blocked on another issue or PR labels Sep 16, 2023
@RiscadoA RiscadoA added this to the 0.0 Nursery milestone Sep 16, 2023
@RiscadoA RiscadoA self-assigned this Sep 16, 2023
This was linked to issues Sep 16, 2023
Add ArrayTrait #483
Closed
Define reflection for std::vector<T> #540
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-546/
on branch gh-pages at 2023-09-28 07:54 UTC

@codecov
Copy link

codecov bot commented Sep 16, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c20ee7c) 30.51% compared to head (9b7badb) 31.80%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   30.51%   31.80%   +1.29%     
==========================================
  Files          88       92       +4     
  Lines        6233     6357     +124     
==========================================
+ Hits         1902     2022     +120     
- Misses       4331     4335       +4
Files Coverage Δ
.../include/cubos/core/reflection/external/vector.hpp 100.00% <100.00%> (ø)
...ore/include/cubos/core/reflection/traits/array.hpp 100.00% <100.00%> (ø)
core/src/cubos/core/reflection/traits/array.cpp 95.55% <95.55%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA removed the S-Blocked Blocked on another issue or PR label Sep 19, 2023
github-actions[bot]
github-actions bot previously requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/tests/reflection/traits/array.cpp Show resolved Hide resolved
core/tests/reflection/traits/array.cpp Show resolved Hide resolved
core/tests/reflection/traits/array.hpp Show resolved Hide resolved
core/src/cubos/core/reflection/traits/array.cpp Outdated Show resolved Hide resolved
core/src/cubos/core/reflection/traits/array.cpp Outdated Show resolved Hide resolved
core/src/cubos/core/reflection/traits/array.cpp Outdated Show resolved Hide resolved
core/src/cubos/core/reflection/traits/array.cpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA dismissed github-actions[bot]’s stale review September 26, 2023 13:42

False positive due to include errors

luishfonseca
luishfonseca reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@luishfonseca luishfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add .view(...)? It would allow the following syntax

for (auto* value : arrayTrait.view(myArray))
{
...
}

RiscadoA and others added 3 commits September 28, 2023 07:42
@RiscadoA
refactor(core): remove unnecessary if
67d46b5
@RiscadoA
docs(core): add expected output to sample
b1af5fe
@RiscadoA @github-actions
fix(core): follow clang-tidy suggestions
f24b4d8 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions[bot]
github-actions bot previously requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/src/cubos/core/reflection/traits/array.cpp Outdated Show resolved Hide resolved
core/include/cubos/core/reflection/traits/array.hpp Outdated Show resolved Hide resolved
core/src/cubos/core/reflection/traits/array.cpp Outdated Show resolved Hide resolved
core/include/cubos/core/reflection/traits/array.hpp Outdated Show resolved Hide resolved
core/src/cubos/core/reflection/traits/array.cpp Outdated Show resolved Hide resolved
core/include/cubos/core/reflection/traits/array.hpp Outdated Show resolved Hide resolved
core/src/cubos/core/reflection/traits/array.cpp Outdated Show resolved Hide resolved
core/include/cubos/core/reflection/traits/array.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot dismissed their stale review September 28, 2023 07:07

No clang-tidy warnings found so I assume my comments were addressed

github-actions[bot]
github-actions bot previously requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/samples/reflection/traits/array/main.cpp Outdated Show resolved Hide resolved
@RiscadoA @github-actions
fix(core): use const in sample for loop
9b7badb 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot dismissed their stale review September 28, 2023 07:56

No clang-tidy warnings found so I assume my comments were addressed

@RiscadoA RiscadoA merged commit 272177a into main Sep 28, 2023
9 checks passed
@RiscadoA RiscadoA deleted the 483-add-arraytrait branch September 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luishfonseca luishfonseca luishfonseca approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@RiscadoA RiscadoA

Labels
A-Core B-Reflection
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging this pull request may close these issues.

Define reflection for std::vector<T> Add ArrayTrait
2 participants
@RiscadoA @luishfonseca