Move SpotLight, PointLight and DirectionalLight from core to engine
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiscadoA
changed the title
SpotLight, PointLight and DirectionalLight from core to engine
RiscadoA
added
A-Core
A-Engine
B-Rendering
C-Code-Quality
|
RiscadoA
force-pushed
the
490-move-spotlight-pointlight-directionallight-from-core-to-engine
branch
from
e4f6dba to
b0b23b1
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 25.55% 25.61% +0.06%
==========================================
Files 93 92 -1
Lines 7173 7156 -17
==========================================
Hits 1833 1833
+ Misses 5340 5323 -17 ☔ View full report in Codecov by Sentry. |
luishfonseca
approved these changes
Sep 25, 2023
RiscadoA
force-pushed
the
490-move-spotlight-pointlight-directionallight-from-core-to-engine
branch
from
b0b23b1 to
d31279e
Compare
RiscadoA
deleted the
490-move-spotlight-pointlight-directionallight-from-core-to-engine
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the old struct
AmbientLightwhich wasn't being used anymore.Splits the
cubos/engine/renderer/light.hppfile intopoint_light.hpp,directional_light.hppandspot_light.hpp.Changes renderer to use the engine lights directly instead of the core lights.
Removes the core lights.
Checklist