Cleanup and document engine-sample.scene
#562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DiogoMendonc-a
changed the title
engine-sample.scene
DiogoMendonc-a
force-pushed
the
474-cleanup-and-document-engine-samplescene
branch
from
2ce503c to
ae48a4f
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 93 93
Lines 7173 7173
=======================================
Hits 1833 1833
Misses 5340 5340 ☔ View full report in Codecov by Sentry. |
RiscadoA
requested changes
Sep 21, 2023
There was a problem hiding this comment.
Thanks for working on this @DiogoMendonc-a!
It would also be nice to reference this example in the scene plugin documentation, as we did with the renderer plugin.
DiogoMendonc-a
force-pushed
the
474-cleanup-and-document-engine-samplescene
branch
from
ae48a4f to
0625a8e
Compare
DiogoMendonc-a
deleted the
474-cleanup-and-document-engine-samplescene
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.