Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clang Tidy #598

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix Clang Tidy #598

merged 1 commit into from
Sep 27, 2023

Conversation

luishfonseca
Copy link
Contributor

No description provided.

@luishfonseca luishfonseca added C-Bug A-Meta B-Build Related to the build configuration labels Sep 26, 2023
@luishfonseca luishfonseca added this to the 0.0 Nursery milestone Sep 26, 2023
@luishfonseca luishfonseca self-assigned this Sep 26, 2023
@luishfonseca luishfonseca linked an issue Sep 26, 2023 that may be closed by this pull request
Fix clang-tidy #597
Closed
@luishfonseca luishfonseca marked this pull request as draft September 26, 2023 23:11
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-598/
on branch gh-pages at 2023-09-27 11:04 UTC

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a05b5d0) 26.92% compared to head (4d6caeb) 26.92%.
Report is 10 commits behind head on main.

❗ Current head 4d6caeb differs from pull request most recent head a702dda. Consider uploading reports for the commit a702dda to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   26.92%   26.92%           
=======================================
  Files          89       89           
  Lines        6797     6797           
=======================================
  Hits         1830     1830           
  Misses       4967     4967
Files Coverage Δ
core/include/cubos/core/memory/endianness.hpp 43.75% <ø> (ø)
core/src/cubos/core/memory/buffer_stream.cpp 60.95% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luishfonseca luishfonseca force-pushed the 597-fix-clang-tidy branch 9 times, most recently from 97849eb to ef98c53 Compare September 27, 2023 00:32
github-actions[bot]
github-actions bot previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/tests/ecs/dispatcher.cpp Outdated Show resolved Hide resolved
core/tests/ecs/dispatcher.cpp Outdated Show resolved Hide resolved
core/include/cubos/core/memory/buffer_stream.hpp Outdated Show resolved Hide resolved
core/src/cubos/core/memory/buffer_stream.cpp Outdated Show resolved Hide resolved
core/src/cubos/core/memory/buffer_stream.cpp Outdated Show resolved Hide resolved
@luishfonseca
Copy link
Contributor Author

The last commit is useful to observe the action behaviour, once approved I will remove it

@luishfonseca luishfonseca force-pushed the 597-fix-clang-tidy branch 3 times, most recently from d055b7e to 85f35a8 Compare September 27, 2023 10:34
github-actions[bot]
github-actions bot previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/include/cubos/core/memory/endianness.hpp Outdated Show resolved Hide resolved
core/include/cubos/core/memory/endianness.hpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/collisions/broad_phase.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase.hpp Outdated Show resolved Hide resolved
@luishfonseca luishfonseca marked this pull request as ready for review September 27, 2023 10:49
@github-actions github-actions bot dismissed stale reviews from themself September 27, 2023 11:04

No clang-tidy warnings found so I assume my comments were addressed

@luishfonseca luishfonseca merged commit 8ffbcf6 into main Sep 27, 2023
8 of 9 checks passed
@luishfonseca luishfonseca deleted the 597-fix-clang-tidy branch September 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@luishfonseca luishfonseca

Labels
A-Meta B-Build Related to the build configuration C-Bug
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging this pull request may close these issues.

Fix clang-tidy
2 participants
@luishfonseca @RiscadoA