Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup, document and rename engine-sample.systems to engine-sample.hello-cubos #599

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Cleanup, document and rename engine-sample.systems to engine-sample.hello-cubos #599

merged 1 commit into from
Sep 28, 2023

Conversation

DiogoMendonc-a
Copy link
Contributor

No description provided.

@DiogoMendonc-a DiogoMendonc-a linked an issue Sep 27, 2023 that may be closed by this pull request
Cleanup, document and rename engine-sample.systems to engine-sample.hello-cubos #475
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-599/
on branch gh-pages at 2023-09-28 13:51 UTC

@DiogoMendonc-a DiogoMendonc-a force-pushed the 475-cleanup-document-and-rename-engine-samplesystems-to-engine-samplehello-cubos branch from 128d177 to 9b4d4ed Compare September 27, 2023 09:07
RiscadoA
RiscadoA requested changes Sep 27, 2023
View reviewed changes
engine/samples/hello-cubos/main.cpp Show resolved Hide resolved
engine/samples/hello-cubos/main.cpp Outdated Show resolved Hide resolved
@DiogoMendonc-a DiogoMendonc-a force-pushed the 475-cleanup-document-and-rename-engine-samplesystems-to-engine-samplehello-cubos branch 2 times, most recently from cae09aa to 7ac2954 Compare September 27, 2023 10:22
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (272177a) 31.80% compared to head (7999b43) 31.80%.
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   31.80%   31.80%           
=======================================
  Files          92       92           
  Lines        6357     6357           
=======================================
  Hits         2022     2022           
  Misses       4335     4335

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RiscadoA
RiscadoA reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to include one component, query and resource. Other samples kinda assume the reader knows what they are.

engine/samples/hello-cubos/main.cpp Outdated Show resolved Hide resolved
engine/samples/hello-cubos/page.md Outdated Show resolved Hide resolved
@DiogoMendonc-a DiogoMendonc-a force-pushed the 475-cleanup-document-and-rename-engine-samplesystems-to-engine-samplehello-cubos branch from 7ac2954 to 0e59654 Compare September 27, 2023 12:28
RiscadoA
RiscadoA requested changes Sep 27, 2023
View reviewed changes
engine/samples/hello-cubos/main.cpp Outdated Show resolved Hide resolved
engine/samples/hello-cubos/main.cpp Outdated Show resolved Hide resolved
engine/samples/hello-cubos/page.md Outdated Show resolved Hide resolved
@DiogoMendonc-a DiogoMendonc-a force-pushed the 475-cleanup-document-and-rename-engine-samplesystems-to-engine-samplehello-cubos branch from 0e59654 to ab52f1a Compare September 27, 2023 12:42
RiscadoA
RiscadoA requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing this

@DiogoMendonc-a DiogoMendonc-a force-pushed the 475-cleanup-document-and-rename-engine-samplesystems-to-engine-samplehello-cubos branch 7 times, most recently from 2340f4e to e056486 Compare September 28, 2023 10:41
@DiogoMendonc-a DiogoMendonc-a force-pushed the 475-cleanup-document-and-rename-engine-samplesystems-to-engine-samplehello-cubos branch from e056486 to 9aecb34 Compare September 28, 2023 10:45
@DiogoMendonc-a DiogoMendonc-a added this to the 0.0 Nursery milestone Sep 28, 2023
RiscadoA
RiscadoA requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 😌 covers a bit of everything. Added some minor nitpicks.
One other thing you should change before merging is suffixing systems with System, e.g. checkEntitiesSystem, since we follow that pattern throughout the engine.

engine/samples/hello-cubos/main.cpp Outdated Show resolved Hide resolved
engine/samples/hello-cubos/page.md Outdated Show resolved Hide resolved
engine/samples/hello-cubos/page.md Outdated Show resolved Hide resolved
@DiogoMendonc-a DiogoMendonc-a force-pushed the 475-cleanup-document-and-rename-engine-samplesystems-to-engine-samplehello-cubos branch from 9aecb34 to 7999b43 Compare September 28, 2023 13:50
RiscadoA
RiscadoA approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rocket it 🚀

@DiogoMendonc-a DiogoMendonc-a merged commit 6a1f44f into main Sep 28, 2023
9 checks passed
@DiogoMendonc-a DiogoMendonc-a deleted the 475-cleanup-document-and-rename-engine-samplesystems-to-engine-samplehello-cubos branch September 28, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

Assignees

@DiogoMendonc-a DiogoMendonc-a

Labels
A-Engine C-Documentation C-Examples
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging this pull request may close these issues.

Cleanup, document and rename engine-sample.systems to engine-sample.hello-cubos
2 participants
@DiogoMendonc-a @RiscadoA