Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views getters and setters should also receive a field name string #610

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Views getters and setters should also receive a field name string #610

merged 2 commits into from
Sep 28, 2023

Conversation

luishfonseca
Copy link
Contributor

@luishfonseca luishfonseca commented Sep 28, 2023 •
edited
Loading

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.

@luishfonseca luishfonseca added A-Core B-Reflection C-Code-Quality A section of code that is hard to understand or change D-Trivial Can be done in 30 minutes labels Sep 28, 2023
@luishfonseca luishfonseca added this to the 0.0 Nursery milestone Sep 28, 2023
@luishfonseca luishfonseca self-assigned this Sep 28, 2023
@luishfonseca luishfonseca linked an issue Sep 28, 2023 that may be closed by this pull request
Views getters and setters should also receive a field name string #609
Closed
@github-actions
Copy link
Contributor

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-610/
on branch gh-pages at 2023-09-28 17:51 UTC

github-actions[bot]
github-actions bot previously requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/src/cubos/core/reflection/traits/fields.cpp Outdated Show resolved Hide resolved
core/src/cubos/core/reflection/traits/fields.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e8ad837) 36.57% compared to head (9bd8b48) 36.57%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   36.57%   36.57%           
=======================================
  Files          89       89           
  Lines        6357     6367   +10     
=======================================
+ Hits         2325     2329    +4     
- Misses       4032     4038    +6
Files Coverage Δ
...re/include/cubos/core/reflection/traits/fields.hpp 100.00% <ø> (ø)
core/src/cubos/core/reflection/traits/fields.cpp 93.02% <40.00%> (-4.46%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luishfonseca @github-actions
refactor(core): clang-tidy
9bd8b48 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot dismissed their stale review September 28, 2023 17:57

No clang-tidy warnings found so I assume my comments were addressed

@luishfonseca luishfonseca force-pushed the 609-views-getters-and-setters-should-also-receive-a-field-name-string branch from ff76001 to 9bd8b48 Compare September 28, 2023 17:57
@luishfonseca luishfonseca merged commit 743fe69 into main Sep 28, 2023
9 checks passed
@luishfonseca luishfonseca deleted the 609-views-getters-and-setters-should-also-receive-a-field-name-string branch September 28, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@luishfonseca luishfonseca

Labels
A-Core B-Reflection C-Code-Quality A section of code that is hard to understand or change D-Trivial Can be done in 30 minutes
Projects
None yet
Milestone
0.0.1 Nursery
Development

Successfully merging this pull request may close these issues.

Views getters and setters should also receive a field name string
2 participants
@luishfonseca @RiscadoA