Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move old serialization code to cubos::core::data::old #616

Merged

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Sep 28, 2023

Description

Moved all existing serialization related code to the core/data/old directory and to the core::data::old namespace.
This was done simply through a few find and replaces.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation (wasn't documented).

@RiscadoA RiscadoA added A-Core C-Code-Quality A section of code that is hard to understand or change B-Serialization labels Sep 28, 2023
@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Sep 28, 2023
@RiscadoA RiscadoA self-assigned this Sep 28, 2023
@github-actions
Copy link
Contributor

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-616/
on branch gh-pages at 2023-09-28 22:04 UTC

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (66bc6ef) 36.57% compared to head (0d5fe48) 36.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   36.57%   36.57%   -0.01%     
==========================================
  Files          89       89              
  Lines        6367     6368       +1     
==========================================
  Hits         2329     2329              
- Misses       4038     4039       +1     
Files Coverage Δ
.../include/cubos/core/data/old/binary_serializer.hpp 100.00% <ø> (ø)
core/include/cubos/core/data/old/context.hpp 100.00% <ø> (ø)
...e/include/cubos/core/data/old/debug_serializer.hpp 0.00% <ø> (ø)
core/include/cubos/core/data/old/deserializer.hpp 100.00% <ø> (ø)
core/include/cubos/core/data/old/package.hpp 83.33% <ø> (ø)
.../include/cubos/core/data/old/serialization_map.hpp 69.23% <ø> (ø)
core/include/cubos/core/data/old/serializer.hpp 55.55% <ø> (ø)
core/include/cubos/core/ecs/blueprint.hpp 94.73% <100.00%> (ø)
core/include/cubos/core/ecs/commands.hpp 95.65% <ø> (ø)
core/include/cubos/core/ecs/component_manager.hpp 100.00% <ø> (ø)
... and 25 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA merged commit f426a85 into main Sep 29, 2023
9 checks passed
@RiscadoA RiscadoA deleted the 436-move-old-serialization-code-to-cuboscoreolddata-namespace branch September 29, 2023 08:15
@RiscadoA RiscadoA linked an issue Sep 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core B-Serialization C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move old serialization code to cubos::core::data::old namespace
2 participants