-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move entity stuff to the ecs/entity
directory
#644
Move entity stuff to the ecs/entity
directory
#644
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
+ Coverage 36.52% 36.56% +0.04%
==========================================
Files 89 92 +3
Lines 6377 6378 +1
==========================================
+ Hits 2329 2332 +3
+ Misses 4048 4046 -2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
2adcb85
to
db332f1
Compare
No clang-tidy warnings found so I assume my comments were addressed
e9d6360
to
f336efd
Compare
Description
ecs/entity
directory.Entity
frommanager.hpp
intoentity.hpp
.std::hash<Entity>
specialization withEntityHash
, which allows us to avoid including<functional>
(yikes) inentity.hpp
.For the third point I had to add new template types to
SerializationMap
to allow specifying custom hash types.Checklist