-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move system stuff to the ecs/system
directory
#649
Merged
RiscadoA
merged 7 commits into
main
from
643-move-system-stuff-to-the-ecssystem-directory
Oct 2, 2023
Merged
Move system stuff to the ecs/system
directory
#649
RiscadoA
merged 7 commits into
main
from
643-move-system-stuff-to-the-ecssystem-directory
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiscadoA
added
A-Core
B-ECS
C-Code-Quality
A section of code that is hard to understand or change
labels
Oct 1, 2023
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 36.56% 36.56%
=======================================
Files 92 92
Lines 6378 6378
=======================================
Hits 2332 2332
Misses 4046 4046
☔ View full report in Codecov by Sentry. |
2 tasks
RiscadoA
force-pushed
the
643-move-system-stuff-to-the-ecssystem-directory
branch
from
October 2, 2023 18:49
2c2b682
to
263daf1
Compare
luishfonseca
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #643.
Description
Moves all system related code to the
ecs/system
dir.Checklist