Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move system stuff to the ecs/system directory #649

Merged
merged 7 commits into from
Oct 2, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Oct 1, 2023

Closes #643.

Description

Moves all system related code to the ecs/system dir.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.

@RiscadoA RiscadoA added A-Core B-ECS C-Code-Quality A section of code that is hard to understand or change labels Oct 1, 2023
@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Oct 1, 2023
@RiscadoA RiscadoA self-assigned this Oct 1, 2023
@RiscadoA RiscadoA added the S-Blocked Blocked on another issue or PR label Oct 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-649/
on branch gh-pages at 2023-10-02 18:50 UTC

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f65b241) 36.56% compared to head (263daf1) 36.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   36.56%   36.56%           
=======================================
  Files          92       92           
  Lines        6378     6378           
=======================================
  Hits         2332     2332           
  Misses       4046     4046           
Files Coverage Δ
core/include/cubos/core/ecs/blueprint.hpp 94.73% <ø> (ø)
core/include/cubos/core/ecs/system/accessors.hpp 100.00% <ø> (ø)
core/include/cubos/core/ecs/system/commands.hpp 95.65% <ø> (ø)
core/include/cubos/core/ecs/system/dispatcher.hpp 82.14% <ø> (ø)
core/include/cubos/core/ecs/system/query.hpp 100.00% <ø> (ø)
core/include/cubos/core/ecs/system/system.hpp 79.12% <ø> (ø)
core/src/cubos/core/ecs/system/commands.cpp 97.29% <ø> (ø)
core/src/cubos/core/ecs/system/dispatcher.cpp 93.98% <ø> (ø)
core/src/cubos/core/ecs/system/system.cpp 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 643-move-system-stuff-to-the-ecssystem-directory branch from 2c2b682 to 263daf1 Compare October 2, 2023 18:49
@RiscadoA RiscadoA removed the S-Blocked Blocked on another issue or PR label Oct 2, 2023
@RiscadoA RiscadoA requested a review from luishfonseca October 2, 2023 18:49
@RiscadoA RiscadoA enabled auto-merge (rebase) October 2, 2023 20:52
@RiscadoA RiscadoA merged commit a2d710a into main Oct 2, 2023
9 checks passed
@RiscadoA RiscadoA deleted the 643-move-system-stuff-to-the-ecssystem-directory branch October 2, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core B-ECS C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move system stuff to the ecs/system directory
2 participants