Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Serializer #652

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Add Serializer #652

merged 4 commits into from
Oct 2, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Oct 2, 2023 •
edited
Loading

Closes #567.

Description

Adds the Serializer base class.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage. Planning on leaving it to the actual implementations.
  • Write new samples.

@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Oct 2, 2023
@RiscadoA RiscadoA self-assigned this Oct 2, 2023
@RiscadoA RiscadoA linked an issue Oct 2, 2023 that may be closed by this pull request
Add Serializer #567
Closed
@RiscadoA RiscadoA requested a review from luishfonseca October 2, 2023 08:52
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-652/
on branch gh-pages at 2023-10-02 20:53 UTC

github-actions[bot]
github-actions bot previously requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/samples/data/ser/custom/main.cpp Outdated Show resolved Hide resolved
core/samples/data/ser/custom/main.cpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA force-pushed the 567-add-serializer branch from 0976f8c to 1d995ee Compare October 2, 2023 08:55
@RiscadoA RiscadoA enabled auto-merge (rebase) October 2, 2023 08:56
@github-actions github-actions bot dismissed their stale review October 2, 2023 08:57

No clang-tidy warnings found so I assume my comments were addressed

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (bba5d01) 36.52% compared to head (c5927a3) 36.44%.
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   36.52%   36.44%   -0.08%     
==========================================
  Files          89       90       +1     
  Lines        6377     6390      +13     
==========================================
  Hits         2329     2329              
- Misses       4048     4061      +13
Files Coverage Δ
core/src/cubos/core/data/ser/serializer.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

luishfonseca
luishfonseca requested changes Oct 2, 2023
View reviewed changes
core/samples/data/ser/custom/page.md Outdated Show resolved Hide resolved
@RiscadoA RiscadoA requested a review from luishfonseca October 2, 2023 20:52
@RiscadoA RiscadoA merged commit 88571ad into main Oct 2, 2023
9 checks passed
@RiscadoA RiscadoA deleted the 567-add-serializer branch October 2, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luishfonseca luishfonseca luishfonseca approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@RiscadoA RiscadoA

Labels
A-Core B-Serialization
Projects
None yet
Milestone
0.1 Jammable Engine
Development

Successfully merging this pull request may close these issues.

Add Serializer
2 participants
@RiscadoA @luishfonseca