Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add voxel palette editor plugin #662

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Add voxel palette editor plugin #662

merged 1 commit into from
Oct 21, 2023

Conversation

roby2014
Copy link
Member

@roby2014 roby2014 commented Oct 4, 2023 •
edited
Loading

Description

  • Added voxel palette editor plugin.
  • Added the plugin to tesseratos sample.
  • Implemented equality operator for AnyAsset

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@roby2014 roby2014 linked an issue Oct 4, 2023 that may be closed by this pull request
Add palette editor #270
Closed
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d2a268) 38.15% compared to head (5d90965) 38.15%.

❗ Current head 5d90965 differs from pull request most recent head da8b534. Consider uploading reports for the commit da8b534 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #662   +/-   ##
=======================================
  Coverage   38.15%   38.15%           
=======================================
  Files          99       99           
  Lines        6576     6576           
=======================================
  Hits         2509     2509           
  Misses       4067     4067

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions[bot]
github-actions bot previously requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-662/
on branch gh-pages at 2023-10-21 17:07 UTC

@roby2014 roby2014 self-assigned this Oct 4, 2023
@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Oct 4, 2023
@github-actions github-actions bot dismissed their stale review October 4, 2023 15:25

No clang-tidy warnings found so I assume my comments were addressed

@roby2014 roby2014 force-pushed the 270-add-palette-editor branch from b7d181e to 9e9d2a6 Compare October 4, 2023 15:54
@RiscadoA RiscadoA changed the title [wip] feat(tools): add palette editor plugin feat(tools): add palette editor plugin Oct 4, 2023
@RiscadoA RiscadoA marked this pull request as draft October 4, 2023 21:04
RiscadoA
RiscadoA requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @roby2014!
By the way, we no longer use git merge, and prefer git rebase in order to have a linear history. You should use git rebase -i to drop the merge commit and reword the existing misc commit to meta. If you need any help/have any questions ping me on discord!

engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
@RiscadoA RiscadoA marked this pull request as ready for review October 4, 2023 21:22
github-actions[bot]
github-actions bot previously requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot dismissed their stale review October 5, 2023 15:25

No clang-tidy warnings found so I assume my comments were addressed

@roby2014 roby2014 force-pushed the 270-add-palette-editor branch from 442635d to 1136433 Compare October 10, 2023 16:44
github-actions[bot]
github-actions bot previously requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

tools/tesseratos/src/main.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot dismissed their stale review October 10, 2023 17:44

No clang-tidy warnings found so I assume my comments were addressed

github-actions[bot]
github-actions bot previously requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/assets/asset.cpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/assets/asset.hpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/tools/palette_editor/plugin.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot dismissed stale reviews from themself October 11, 2023 19:41

No clang-tidy warnings found so I assume my comments were addressed

@roby2014 roby2014 force-pushed the 270-add-palette-editor branch 2 times, most recently from 843773e to 7b768c8 Compare October 13, 2023 22:52
@roby2014 roby2014 force-pushed the 270-add-palette-editor branch from c182413 to 27c9057 Compare October 15, 2023 18:50
@roby2014 roby2014 added the S-Blocked Blocked on another issue or PR label Oct 15, 2023
@roby2014
Copy link
Member Author

I think first we should implement #709 since it would be useful here.

@roby2014 roby2014 force-pushed the 270-add-palette-editor branch from 27c9057 to 40fa299 Compare October 15, 2023 23:47
github-actions[bot]
github-actions bot previously requested changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/tools/voxel_palette_editor/plugin.cpp Outdated Show resolved Hide resolved
@roby2014 roby2014 force-pushed the 270-add-palette-editor branch from 539dbe3 to d6590cf Compare October 16, 2023 14:24
github-actions[bot]
github-actions bot previously requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/tools/voxel_palette_editor/plugin.cpp Show resolved Hide resolved
engine/src/cubos/engine/tools/voxel_palette_editor/plugin.cpp Show resolved Hide resolved
engine/src/cubos/engine/tools/voxel_palette_editor/plugin.cpp Show resolved Hide resolved
@roby2014 roby2014 force-pushed the 270-add-palette-editor branch 6 times, most recently from f1bb0d1 to 24f4aa2 Compare October 16, 2023 19:09
@roby2014 roby2014 requested a review from RiscadoA October 16, 2023 20:34
@roby2014 roby2014 removed the S-Blocked Blocked on another issue or PR label Oct 16, 2023
RiscadoA
RiscadoA approved these changes Oct 16, 2023
View reviewed changes
tools/tesseratos/assets/main_copy.pal.meta Outdated Show resolved Hide resolved
@RiscadoA
Copy link
Member

LGTM, ty for working on this!

@roby2014 roby2014 force-pushed the 270-add-palette-editor branch from 210e0f8 to ea11ff4 Compare October 16, 2023 21:45
@roby2014 roby2014 force-pushed the 270-add-palette-editor branch 2 times, most recently from 19d4806 to 5d90965 Compare October 21, 2023 17:06
@github-actions github-actions bot dismissed stale reviews from themself October 21, 2023 17:35

No clang-tidy warnings found so I assume my comments were addressed

@roby2014 roby2014 force-pushed the 270-add-palette-editor branch from 29f5e0e to 34e8127 Compare October 21, 2023 17:36
@roby2014 roby2014 force-pushed the 270-add-palette-editor branch from 34e8127 to da8b534 Compare October 21, 2023 17:37
@roby2014 roby2014 enabled auto-merge (rebase) October 21, 2023 17:37
@roby2014 roby2014 merged commit 669331c into main Oct 21, 2023
7 checks passed
@roby2014 roby2014 deleted the 270-add-palette-editor branch October 21, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiogoMendonc-a DiogoMendonc-a DiogoMendonc-a approved these changes

@RiscadoA RiscadoA RiscadoA approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@roby2014 roby2014

Labels
A-Engine B-Tools
Projects
None yet
Milestone
0.1 Jammable Engine
Development

Successfully merging this pull request may close these issues.

Add palette editor
3 participants
@roby2014 @RiscadoA @DiogoMendonc-a