Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Collider and ColliderShape #666

Merged
merged 9 commits into from
Oct 5, 2023
Merged

Split Collider and ColliderShape #666

merged 9 commits into from
Oct 5, 2023

Conversation

luishfonseca
Copy link
Contributor

@luishfonseca luishfonseca commented Oct 4, 2023 •
edited
Loading

Description

There's shared behavior between colliders, let's make use of it.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.

@luishfonseca luishfonseca added A-Engine B-Collisions D-Trivial Can be done in 30 minutes labels Oct 4, 2023
@luishfonseca luishfonseca self-assigned this Oct 4, 2023
@luishfonseca luishfonseca requested a review from RiscadoA as a code owner October 4, 2023 21:28
@luishfonseca luishfonseca linked an issue Oct 4, 2023 that may be closed by this pull request
Split Collider and ColliderShape #660
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-666/
on branch gh-pages at 2023-10-04 23:22 UTC

@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9f1b37d) 36.38% compared to head (9eeda41) 36.38%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage   36.38%   36.38%           
=======================================
  Files          92       92           
  Lines        6381     6381           
=======================================
  Hits         2322     2322           
  Misses       4059     4059
Files Coverage Δ
core/include/cubos/core/geom/box.hpp 100.00% <ø> (ø)
core/include/cubos/core/geom/capsule.hpp 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luishfonseca luishfonseca force-pushed the 660-split-collider-and-collidershape branch from 5c202b5 to e10a607 Compare October 4, 2023 21:52
@luishfonseca luishfonseca requested a review from RiscadoA October 4, 2023 23:22
@luishfonseca luishfonseca added this to the 0.1 Jammable Engine milestone Oct 5, 2023
This was referenced Oct 5, 2023
Closed
Merged
@luishfonseca luishfonseca force-pushed the 660-split-collider-and-collidershape branch from 0a38e48 to 9eeda41 Compare October 5, 2023 12:41
@luishfonseca luishfonseca requested a review from RiscadoA October 5, 2023 12:46
@luishfonseca luishfonseca merged commit c3fa79d into main Oct 5, 2023
9 checks passed
@luishfonseca luishfonseca deleted the 660-split-collider-and-collidershape branch October 5, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

Assignees

@luishfonseca luishfonseca

Labels
A-Engine B-Collisions D-Trivial Can be done in 30 minutes
Projects
None yet
Milestone
0.1 Jammable Engine
Development

Successfully merging this pull request may close these issues.

Split Collider and ColliderShape
3 participants
@luishfonseca @RiscadoA @roby2014