Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): only compile correct version code #674

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

DiogoMendonc-a
Copy link
Contributor

No description provided.

@DiogoMendonc-a DiogoMendonc-a linked an issue Oct 5, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-05 16:07 UTC

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c29e4ef) 36.38% compared to head (5745733) 36.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   36.38%   36.38%           
=======================================
  Files          92       92           
  Lines        6381     6381           
=======================================
  Hits         2322     2322           
  Misses       4059     4059           
Files Coverage Δ
core/src/cubos/core/ecs/entity/hash.cpp 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@DiogoMendonc-a DiogoMendonc-a merged commit 6ba1932 into main Oct 5, 2023
9 checks passed
@DiogoMendonc-a DiogoMendonc-a deleted the 673-error-on-x86-compilation branch October 5, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on x86 compilation
2 participants