-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract broad-phase to plugin #679
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
=======================================
Coverage 36.38% 36.38%
=======================================
Files 92 92
Lines 6381 6381
=======================================
Hits 2322 2322
Misses 4059 4059 ☔ View full report in Codecov by Sentry. |
39f3092
to
db4adfa
Compare
db4adfa
to
fd99970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better. Will go to sleep now so I'll leave it approved. Feel free to merge it after addressing my comments.
Description
Split monolith resource into
SweepAndPrune
andCandidates
, the latter will be removed once we #656Move broadphase to its own plugin
Checklist