Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract broad-phase to plugin #679

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

luishfonseca
Copy link
Contributor

@luishfonseca luishfonseca commented Oct 6, 2023

Description

Split monolith resource into SweepAndPrune and Candidates, the latter will be removed once we #656
Move broadphase to its own plugin

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.

@luishfonseca luishfonseca added this to the 0.1 Jammable Engine milestone Oct 6, 2023
@luishfonseca luishfonseca self-assigned this Oct 6, 2023
@luishfonseca luishfonseca requested a review from RiscadoA as a code owner October 6, 2023 22:33
@luishfonseca luishfonseca linked an issue Oct 6, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-07 09:10 UTC

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/collisions/broad_phase/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/plugin.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5d133d8) 36.38% compared to head (7533a54) 36.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   36.38%   36.38%           
=======================================
  Files          92       92           
  Lines        6381     6381           
=======================================
  Hits         2322     2322           
  Misses       4059     4059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luishfonseca luishfonseca force-pushed the 678-move-broadphase-phase-to-its-plugin branch from 39f3092 to db4adfa Compare October 6, 2023 22:41
@luishfonseca luishfonseca force-pushed the 678-move-broadphase-phase-to-its-plugin branch from db4adfa to fd99970 Compare October 6, 2023 22:42
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/collisions/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase/plugin.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase/plugin.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/collisions/broad_phase/plugin.cpp Outdated Show resolved Hide resolved
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Will go to sleep now so I'll leave it approved. Feel free to merge it after addressing my comments.

@luishfonseca luishfonseca enabled auto-merge (rebase) October 6, 2023 23:42
@luishfonseca luishfonseca merged commit 481ad37 into main Oct 7, 2023
9 checks passed
@luishfonseca luishfonseca deleted the 678-move-broadphase-phase-to-its-plugin branch October 7, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move broadphase phase to its plugin
2 participants