Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reflection for Entity #689

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Oct 7, 2023

No description provided.

@RiscadoA RiscadoA linked an issue Oct 7, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/pr-preview/pr-689/
on branch gh-pages at 2023-10-07 14:56 UTC

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (273f8d8) 36.38% compared to head (f6c025e) 36.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   36.38%   36.34%   -0.04%     
==========================================
  Files          92       92              
  Lines        6381     6388       +7     
==========================================
  Hits         2322     2322              
- Misses       4059     4066       +7     
Files Coverage Δ
core/include/cubos/core/ecs/entity/entity.hpp 100.00% <ø> (ø)
core/src/cubos/core/ecs/entity/entity.cpp 69.04% <0.00%> (-13.81%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA merged commit 8f7192f into main Oct 7, 2023
9 checks passed
@RiscadoA RiscadoA deleted the 635-implement-reflection-for-entity branch October 7, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement reflection for Entity
2 participants