Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reflection for all components #694

Merged
merged 18 commits into from
Oct 8, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Oct 8, 2023

Description

Implements reflection for all components and for their fields.
Adds some utilities to make this easier.

Read this commit by commit, I split it nicely 😌

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@RiscadoA RiscadoA linked an issue Oct 8, 2023 that may be closed by this pull request
@RiscadoA RiscadoA requested a review from luishfonseca as a code owner October 8, 2023 12:55
@RiscadoA RiscadoA self-assigned this Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-08 15:23 UTC

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (b014ec7) 36.34% compared to head (255c8d5) 36.31%.

❗ Current head 255c8d5 differs from pull request most recent head f728064. Consider uploading reports for the commit f728064 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   36.34%   36.31%   -0.04%     
==========================================
  Files          92       96       +4     
  Lines        6388     6427      +39     
==========================================
+ Hits         2322     2334      +12     
- Misses       4066     4093      +27     
Files Coverage Δ
core/include/cubos/core/geom/box.hpp 100.00% <ø> (ø)
core/include/cubos/core/geom/capsule.hpp 100.00% <ø> (ø)
core/include/cubos/core/reflection/reflect.hpp 100.00% <ø> (ø)
...re/include/cubos/core/reflection/traits/fields.hpp 100.00% <100.00%> (ø)
core/src/cubos/core/reflection/external/uuid.cpp 100.00% <100.00%> (ø)
core/src/cubos/core/reflection/traits/fields.cpp 93.12% <100.00%> (+0.10%) ⬆️
tools/quadrados-gen/src/main.cpp 0.00% <0.00%> (ø)
core/src/cubos/core/geom/box.cpp 0.00% <0.00%> (ø)
core/src/cubos/core/geom/capsule.cpp 0.00% <0.00%> (ø)
...re/include/cubos/core/ecs/component/reflection.hpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA enabled auto-merge (rebase) October 8, 2023 15:17
@RiscadoA RiscadoA merged commit 35ba758 into main Oct 8, 2023
7 checks passed
@RiscadoA RiscadoA deleted the 691-implement-reflection-for-all-components branch October 8, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement reflection for all components
2 participants