Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build error on flutter 3.24.0 #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ktakayama
Copy link

Fix the following error that occurs when compiling for an Android build on Flutter 3.24.0

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':external_app_launcher:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
   > Android resource linking failed
     ERROR: /Users/takayama/ghq/github.com/medpeer-dev/navel/build/external_app_launcher/intermediates/merged_res/release/values/values.xml:194: AAPT: error: resource android:attr/
lStar not found.


defaultConfig {
minSdkVersion 16
Copy link

@bigbenyayi bigbenyayi Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the minSdkVersion need to be changed? I think it should work leaving it at 16

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigbenyayi
There were some remnants from when I was conducting operation tests.
I'll revert them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for creating this PR

@kunatastic
Copy link

Hey team!!

Any update on this

@josephmangmang
Copy link

Hi also same issue

@bonellia
Copy link

Any plans to merge this soon? Thanks in advance.

@bonellia
Copy link

Hi @bigbenyayi
It seems @ktakayama is inactive.
I see that you already approved these changes. Any chance you can merge it?

@bigbenyayi
Copy link

I sadly do not have the rights to merge on this project

@ktakayama
Copy link
Author

I can't merge this PR because I don't have write access to this repository

@bonellia
Copy link

I see, thanks anyways. We ended up using URL launcher plugin for those who are interested in.
We can launch store page if said application is not installed. Here is a sample usage:

canLaunchUrl(Uri.parse('spotify://')).then((bool result) {
  if (result == true) {
    launchUrl(Uri.parse('spotify://'),
        mode: LaunchMode.externalApplication);
  } else {
    if (Platform.isAndroid) {
      String appPackageName = 'com.spotify.music';
      launchUrl(Uri.parse("https://play.google.com/store/apps/details?id=" + appPackageName));
    }
    if (Platform.isIOS) {
      launchUrl(Uri.parse('itms-apps://itunes.apple.com/us/app/spotify-music-and-podcasts/id324684580'));
    }
  }
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants