Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build error on flutter 3.24.0 #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

fix: build error on flutter 3.24.0 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ apply plugin: 'com.android.library'

android {
namespace 'com.example.launchexternalapp'
compileSdkVersion 28
compileSdkVersion 31

defaultConfig {
minSdkVersion 16
Copy link

@bigbenyayi bigbenyayi Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the minSdkVersion need to be changed? I think it should work leaving it at 16

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigbenyayi
There were some remnants from when I was conducting operation tests.
I'll revert them.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for creating this PR

}
lintOptions {
disable 'InvalidPackage'
}
}
}
3 changes: 1 addition & 2 deletions android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
org.gradle.jvmargs=-Xmx1536M
android.enableR8=true
android.useAndroidX=true
android.enableJetifier=true
android.enableJetifier=true