Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new api for send a refresh-token #1216

Merged
merged 6 commits into from
Feb 9, 2024
Merged

feat: add new api for send a refresh-token #1216

merged 6 commits into from
Feb 9, 2024

Conversation

guerinoni
Copy link
Contributor

@guerinoni guerinoni commented Jan 30, 2024

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Size Change: +2.16 kB (+1%)

Total Size: 345 kB

Filename Size Change
dist/browser.es.js 74.7 kB +605 B (+1%)
dist/browser.full-bundle.min.js 45 kB +126 B (0%)
dist/browser.js 75.5 kB +410 B (+1%)
dist/index.es.js 74.7 kB +610 B (+1%)
dist/index.js 75.5 kB +412 B (+1%)

compressed-size-action

@guerinoni guerinoni changed the title feat: Add new api for send a refresh-token feat: add new api for send a refresh-token Jan 30, 2024
@guerinoni guerinoni force-pushed the refresh-token branch 2 times, most recently from c1b701b to 5195cff Compare January 31, 2024 14:10
@oliverlaz
Copy link
Member

hey @guerinoni, on second thought, we can make this integration even easier.
What if the client handles the token.expiring event internally and whenever it arrives, it invokes the tokenProvider() and automatically sends the new token to the backend? This way, all of our customers will automatically get this feature.

src/client.ts Outdated Show resolved Hide resolved
oliverlaz
oliverlaz previously approved these changes Feb 8, 2024
@guerinoni guerinoni enabled auto-merge (squash) February 9, 2024 08:38
@guerinoni guerinoni requested a review from oliverlaz February 9, 2024 08:38
@guerinoni guerinoni merged commit af8828b into master Feb 9, 2024
6 checks passed
@guerinoni guerinoni deleted the refresh-token branch February 9, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants