fix: ensure stable sort #1130
Merged
fix: ensure stable sort #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
requested review from
santhoshvai,
szuperaz,
vishalnarkhede,
MartinCupela,
khushal87 and
arnautov-anton
| @@ -69,7 +69,7 @@ describe('CallState', () => { | |||
|
|
|||
| const ps2 = state.participants; | |||
| // should resolve in initial - non-mutated state as set at the beginning | |||
| expect(ps2.map((p) => p.name)).toEqual(['A', 'B', 'C', 'D', 'E', 'F']); | |||
| expect(ps2.map((p) => p.name)).toEqual(['F', 'B', 'E', 'A', 'C', 'D']); | |||
There was a problem hiding this comment.
Suggested change
| expect(ps2.map((p) => p.name)).toEqual(['F', 'B', 'E', 'A', 'C', 'D']); | |
| expect(ps2.map((p) => p.name)).toMatchInlineSnapshot(...); |
Can we do .toMatchInlineSnapshot instead (like here)? The outputs that vitest gives when it compares arrays is super unreadable and updating it manually is super annoying (not that we should do that often but still).
There was a problem hiding this comment.
I'd rather do that at some other time. There are plenty of places we would need to align.
arnautov-anton
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure Stable Sorting by mutating the source participant array.