Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Drain, corresponding brush and new flag #51

Merged
merged 12 commits into from
Mar 21, 2021
Merged

Adding Drain, corresponding brush and new flag #51

merged 12 commits into from
Mar 21, 2021

Conversation

Firigion
Copy link
Collaborator

@Firigion Firigion commented Feb 5, 2021

Drain will remove all liquid connected to the block the player is standing in. By default it does it with some medium range (I think 25?), but the user can specify another value. If there's a selection and the player is standing within it and doesn't specify a radius, then the drain is performed within the selection.

The drain brush is basically the same, but it begins draining in the block the user clicked. Since brush traces usually go through liquids to target the blocks behind them, I added a new flag -l that when applied to the creation of a brush, will make that brush target liquids as well as blocks. Drain brush defaults to that behavior, of course. While I was adding the behavior for the flag, I also fixed one of the bugs in #28, now there's only one missing.

The implementation of drain is using the flood fill functionality in the background. Maybe there's a better way to do it, but that's what I could come up with.

Also fixed an unreported bug in selection move caused by it using an old function that had been deleted.

BisUmTo
BisUmTo previously approved these changes Feb 10, 2021
@Firigion Firigion mentioned this pull request Feb 13, 2021
@Firigion
Copy link
Collaborator Author

This PR now also contains #55, since it was merged into this one. Fo read that one if you want to comment on the functionality added there.

Copy link
Owner

@Ghoulboy78 Ghoulboy78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good, just some things to worked out.

world-edit.sc Outdated Show resolved Hide resolved
world-edit.sc Outdated Show resolved Hide resolved
@Ghoulboy78 Ghoulboy78 added this to the v1.3.0 milestone Mar 21, 2021
@Ghoulboy78 Ghoulboy78 merged commit 973ef2c into master Mar 21, 2021
@Ghoulboy78 Ghoulboy78 deleted the drain branch March 21, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants