-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Drain, corresponding brush and new flag #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BisUmTo
previously approved these changes
Feb 10, 2021
Merged
This PR now also contains #55, since it was merged into this one. Fo read that one if you want to comment on the functionality added there. |
Ghoulboy78
requested changes
Mar 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good, just some things to worked out.
Ghoulboy78
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drain will remove all liquid connected to the block the player is standing in. By default it does it with some medium range (I think 25?), but the user can specify another value. If there's a selection and the player is standing within it and doesn't specify a radius, then the drain is performed within the selection.
The drain brush is basically the same, but it begins draining in the block the user clicked. Since brush traces usually go through liquids to target the blocks behind them, I added a new flag
-l
that when applied to the creation of a brush, will make that brush target liquids as well as blocks. Drain brush defaults to that behavior, of course. While I was adding the behavior for the flag, I also fixed one of the bugs in #28, now there's only one missing.The implementation of drain is using the flood fill functionality in the background. Maybe there's a better way to do it, but that's what I could come up with.
Also fixed an unreported bug in
selection move
caused by it using an old function that had been deleted.