Modernize build #22
Modernize build #22
Conversation
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.10-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip | |||
There was a problem hiding this comment.
That's a bit nasty to hide that in here 😉
There was a problem hiding this comment.
Not sure what you mean? Is that a big change?
There was a problem hiding this comment.
No, but it's totally unrelated to the commit title of "Remove DefaultSelfResolvingDependency", isn't it?
There was a problem hiding this comment.
Oh yea 100% sorry about that, that repo usually doesn't get much review, I'll make sure to make cleaner commits moving on!
| * We need Java <= 17 until we update the embedded gr8 | ||
| * See https://issuetracker.google.com/u/2/issues/365578411 | ||
| */ | ||
| check(JavaVersion.current() <= JavaVersion.VERSION_17) { |
There was a problem hiding this comment.
Should this use the Gradle toolchain mechanism instead?
There was a problem hiding this comment.
Not the biggest toolchain fan. What I really want is to use Java 23 but this requires https://issuetracker.google.com/u/2/issues/365578411
There was a problem hiding this comment.
this requires https://issuetracker.google.com/u/2/issues/365578411
That's marked as fixed. But I guess there's no release with it yet?
There was a problem hiding this comment.
It should be released by now. What we need to do to update R8 in here and then make a new release of Gr8 and then use that new Gr8 release in main and then we can remove the limitation. Bootstrap all the way down 😅
Note that in this specific case, toolchains wouldn't help anyways because R8 takes the runtime libs from the current JRE (unless we used a separate JavaExec task to run R8 itself but there are so many hours in a day sadly).
See #21