Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize build #22

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Modernize build #22

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40138a1
modernize build
martinbonnin Sep 9, 2024
2990b31
update bootstrapped gr8
martinbonnin Sep 9, 2024
659a907
Remove DefaultSelfResolvingDependency
martinbonnin Oct 17, 2024
ba90d36
add apiDump
martinbonnin Oct 17, 2024
00d2c22
We need to build with Java <= 17 for now
martinbonnin Oct 17, 2024
ae368b2
Switch CI to ubuntu
martinbonnin Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,10 @@ include(":gr8-plugin")
include(":gr8-plugin-external")
include(":gr8-plugin-common")

/**
* We need Java <= 17 until we update the embedded gr8
* See https://issuetracker.google.com/u/2/issues/365578411
*/
check(JavaVersion.current() <= JavaVersion.VERSION_17) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use the Gradle toolchain mechanism instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the biggest toolchain fan. What I really want is to use Java 23 but this requires https://issuetracker.google.com/u/2/issues/365578411

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requires https://issuetracker.google.com/u/2/issues/365578411

That's marked as fixed. But I guess there's no release with it yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be released by now. What we need to do to update R8 in here and then make a new release of Gr8 and then use that new Gr8 release in main and then we can remove the limitation. Bootstrap all the way down 😅

Note that in this specific case, toolchains wouldn't help anyways because R8 takes the runtime libs from the current JRE (unless we used a separate JavaExec task to run R8 itself but there are so many hours in a day sadly).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #23 to track this.

"This project needs to be run with Java 17 or higher (found: ${JavaVersion.current()})."
}
Loading