Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from raw json.ld to py module #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gustavodemorais
Copy link
Collaborator

@gustavodemorais gustavodemorais commented Jul 20, 2019

Related: #1 and HTTP-APIs/hydra-python-core#29

Simply changing the format so we import:

from hydra-flock-vocab.hydra_flock import flock_doc

@vddesai1871
Copy link
Collaborator

Probably we'll need to change literals true, false, and null to strings as it is a python dict now.

@vddesai1871
Copy link
Collaborator

Also I noticed an old typo on line 87.

@gustavodemorais
Copy link
Collaborator Author

Can I simply replace it with the dict in hydrus? https://github.com/HTTP-APIs/hydrus/blob/develop/hydrus/samples/hydra_doc_sample.py

I think changing the file format might be a problem for the demo, so if Akshay says so I'll just close this issue and add one more file so we have it on both formats.

@vddesai1871
Copy link
Collaborator

Can I simply replace it with the dict in hydrus? https://github.com/HTTP-APIs/hydrus/blob/develop/hydrus/samples/hydra_doc_sample.py

Yeah you can.

I think changing the file format might be a problem for the demo, so if Akshay says so I'll just close this issue and add one more file so we have it on both formats.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants