Improvement/nsis on GitHub ci #8
Conversation
NSIS has good integration with Conda, whichexists on GitHub in the form of Miniconda. We can leverage this for releases. Signed-off-by: Nick Boyd <[email protected]>
…igger NSIS compiler. Enumerates *.nsi files within the windows installer directory and attempts to run on them. Signed-off-by: Nick Boyd <[email protected]>
.github/workflows/nsis.yml
Outdated
| - name: Upload artifacts | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: "hobovr_setup.exe" # Get the Output Name |
There was a problem hiding this comment.
This really needs to be a value extracted from the .nsi file in the future, especially if we have multiple outputs.
I'll add this to the TODO of #5
There was a problem hiding this comment.
Honestly, this is a pretty big change already that's been in the works for about a week, so I think moving extra work into todos for after merging is a good idea. I'm not really sure how hard extracting the exe name from the nsi file and putting it in the yml will be though.
There was a problem hiding this comment.
@SimLeek I've got this issue about 90% solved using SED in a separate branch already.
Should I fold it into this PR?
There was a problem hiding this comment.
I mean, if it's 100% solved, sure. From experience though, that last 10% can take 50% of the time.
| on: | ||
| workflow_run: | ||
| workflows: [ Build ] | ||
| types: [ completed ] |
There was a problem hiding this comment.
Let me know if I should limit this script running to Releases only.
Personally though, I would recommend having a separate Release workflow that executes after the build and nsis/etc workflows to retrieve artifacts from Release tagged builds and creates a proper release here on GitHub.
That way, we could refactor the online installers to always pull the latest release, or to pull specific releases if needed.
There was a problem hiding this comment.
I really like the idea of a proper release.
As to whether the script should be limited to releases only, the only reason I could think of for that is size. If one of the installers bundles too much together and pushes us towards some limit, then that could be bad. Otherwise, it'd be nice to click on a specific merge and be able to install it and test it quickly.
…r Upload Used SED to extract and prepare GitHub output variable. Piped output has to be different for windows powershell: instead of Signed-off-by: Nick Boyd <[email protected]>
Piped output has to be different for windows powershell: instead of Signed-off-by: Nick Boyd <[email protected]>
Signed-off-by: Nick Boyd <[email protected]>
Modified NSIS installer to allow for automated Conda execute.
Implemented GitHub workflow to enumerate *.nsi files and run Conda execute over them.