-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/nsis on GitHub ci #8
Open
Minothor
wants to merge
5
commits into
HoboVR-Labs:master
Choose a base branch
from
Minothor:improvement/nsis_on_github_ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4b19710
NSIS: hobovr_installer.nsi - Converted header for Conda
Minothor 59d51d5
GITHUB: nsis.yml - workflow to listen to pushes on Main branch and tr…
Minothor 7f76df1
GITHUB: nsis.yml: Extracts OutFile data from the Designated Script fo…
Minothor fb41991
GITHUB: nsis.yml: Updated the deprecated syntax:
Minothor 998f65f
GITHUB: nsis.yml: Removed Debug step
Minothor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
name: nsis | ||
|
||
on: | ||
workflow_run: | ||
workflows: [ Build ] | ||
types: [ completed ] | ||
workflow_dispatch: | ||
|
||
jobs: | ||
config: | ||
if: ${{ github.event.workflow_run.conclusion == 'success' }} | ||
runs-on: ubuntu-latest | ||
outputs: | ||
matrix: ${{ steps.files.outputs.matrix }} | ||
branch: ${{ steps.branch-ref.outputs.name }} | ||
steps: | ||
- uses: actions/checkout@master | ||
with: | ||
ref: ${{ github.event.workflow_run.head_branch }} | ||
|
||
- name: Return Branch | ||
id: branch-ref | ||
run: echo "name=${{ github.event.workflow_run.head_branch }}" >> $GITHUB_OUTPUT | ||
|
||
- name: Get Script Files | ||
id: list-files | ||
uses: Rishabh510/Path-lister-action@master | ||
with: | ||
path: installers/ | ||
type: .nsi | ||
|
||
- name: Return Script Files | ||
id: files | ||
run: echo "matrix=$(echo "${{ steps.list-files.outputs.paths }}" | sed 's/\//\\/g' | jq --raw-input --compact-output '[splits(" ") | select(length > 0)]')" >> $GITHUB_OUTPUT | ||
|
||
make-installer: | ||
runs-on: windows-latest | ||
needs: [ config ] | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
file: ${{ fromJson(needs.config.outputs.matrix) }} | ||
steps: | ||
- uses: actions/checkout@master | ||
with: | ||
ref: ${{ github.event.workflow_run.head_branch }} | ||
|
||
- name: Download artifact | ||
uses: dawidd6/action-download-artifact@v2 | ||
with: | ||
workflow: ${{ github.event.workflow_run.workflow_id }} | ||
workflow_conclusion: success | ||
name: hobovr-build-windows-latest | ||
path: ${{ github.workspace }} | ||
|
||
- name: Create nsis installer | ||
id: create-installer | ||
shell: powershell | ||
run: | | ||
"$CONDA\bin\conda.bat execute ${{ matrix.file }}" | ||
working-directory: ${{ github.workspace }}\installers\win | ||
|
||
- name: Identify Compiled Installer | ||
id: find-installer | ||
shell: powershell | ||
run: | | ||
$exec_file=sed -rn 's/OutFile \"(.*)\"$/\1/p' ./${{ matrix.file }} | ||
echo "executable=$exec_file" >> $Env:GITHUB_OUTPUT | ||
working-directory: ${{ github.workspace }} | ||
|
||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v3 | ||
with: | ||
name: ${{ steps.find-installer.outputs.executable }} | ||
path: | | ||
${{ github.workspace }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I should limit this script running to Releases only.
Personally though, I would recommend having a separate Release workflow that executes after the build and nsis/etc workflows to retrieve artifacts from Release tagged builds and creates a proper release here on GitHub.
That way, we could refactor the online installers to always pull the latest release, or to pull specific releases if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the idea of a proper release.
As to whether the script should be limited to releases only, the only reason I could think of for that is size. If one of the installers bundles too much together and pushes us towards some limit, then that could be bad. Otherwise, it'd be nice to click on a specific merge and be able to install it and test it quickly.