[Bug Fix] Add missing sync_progress call for parallel play #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emailweixu
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bug where certain schedulers had their progresses set to 0 incorrectly when
--parallel_play > 1. After debugging, I found that this only occurred for process specific code (e.g., tasks) and did not affect the main process's schedulers (e.g., DeltaControl). Furthermore, when setting parallel_play to 0, all schedulers were properly set, which heightened my suspicion of there being a syncing issue when creating parallel processes.This PR solves this issue by adding an
env_sync_progress()call before the play loop starts. Now, all process-specific schedulers are properly initialized and parallel_play works as expected.