Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixrule(list_markup_review): #text nodes not visited on prevNode causing false positive #2094

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fixrule(list_markup_review): #text nodes not visited on prevNode causing false positive #2094

merged 3 commits into from
Nov 13, 2024

Conversation

tombrunet
Copy link
Member

  • Rule bug: list_markup_review

This PR is related to the following issue(s):

Testing reference:

  • Testcase added

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy added the engine Issues in the accessibility-checker-engine component label Nov 13, 2024
@tombrunet tombrunet merged commit 0b5921c into master Nov 13, 2024
17 checks passed
@tombrunet tombrunet deleted the bug-list-prevnode branch November 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunguoy shunguoy shunguoy approved these changes

Assignees

@tombrunet tombrunet

Labels
engine Issues in the accessibility-checker-engine component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombrunet @shunguoy