Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixrule(list_markup_review): #text nodes not visited on prevNode causing false positive #2094

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fixrule(list_markup_review): #text nodes not visited on prevNode causing false positive #2094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a0a31a
Bug found by DCS related to list, but cause by prevNode
tombrunet Nov 13, 2024
f08d247
Merge branch 'master' into bug-list-prevnode
shunguoy Nov 13, 2024
094fb09
Merge branch 'master' into bug-list-prevnode
tombrunet Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v2/dom/DOMWalker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export class DOMWalker {
}
}
} while (
(this.node.nodeType !== 1 /* Node.ELEMENT_NODE */ && this.node.nodeType !== 11)
(this.node.nodeType !== 1 /* Node.ELEMENT_NODE */ && this.node.nodeType !== 11 && this.node.nodeType !== 3 )
|| (this.node.nodeType === 1 && (this.node as Element).getAttribute("aChecker") === "ACE")
);
return true;
Expand Down
47 changes: 47 additions & 0 deletions ...r-engine/test/v2/checker/accessibility/rules/list_markup_review_ruleunit/dcs-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

<!--
/******************************************************************************
Copyright:: 2020- IBM, Inc

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*****************************************************************************/
-->

<html lang="en">

<head>
<title>RPT Test Suite</title>
</head>

<body>
<main>
<div>
<p id="debug1">Create groups in <span class="ph">Turbonomic</span> so you can manage Database Servers with ease.
To create groups, go to <strong>Settings &gt; Groups</strong>, and then select <strong>New Group &gt; Database
Server</strong>. In the page that displays, choose <strong>Dynamic</strong> (recommended) and then set the
filter as follows:</p>
</div>
</main>

<script type="text/javascript">
UnitTest = {
ruleIds: ["list_markup_review"],
results: [

]
};
//]]>
</script></body>

</html>
Loading