Get Collection Items extension - facets - filter queries - sort/type #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
g-saracca
changed the title
g-saracca
changed the title
src/collections/infra/repositories/transformers/collectionTransformers.ts
Outdated
Show resolved
Hide resolved
|
@ekraffmiller all changes addressed, thanks for the review! |
ekraffmiller
approved these changes
Dec 12, 2024
|
@g-saracca I realized there is one more change needed, there is a SortType
I'm going to put the PR back to InReview, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Extends the Get Collection Items use case.
Now returns the
facetsaccording to the search.Also now accepts 3 more properties in the
CollectionSearchCriteria-sort,orderandfilterQueries.sort: 'name' or 'date'type:'asc' or 'desc'filterQueries: an strings Array of typestring:stringWhich issue(s) this PR closes:
Suggestions on how to test this:
Visual code inspection and run tests.
Is there a release notes update needed for this change?:
No