Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetDatasetLocks use case #99

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Oct 19, 2023

What this PR does / why we need it:

Adds use case for retrieving dataset locks.

This feature is required for the SPA.

Which issue(s) this PR closes:

Related Dataverse PRs:

Depends on:

Suggestions on how to test this:

  • Visual inspection of the code
  • Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

N/A

Additional documentation:

None

@GPortas GPortas changed the title Added: GetDatasetLocks use case (pending repository logic and tests) Add GetDatasetLocks use case Oct 19, 2023
@GPortas GPortas marked this pull request as ready for review October 20, 2023 12:02
@GPortas GPortas added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 26, 2023
@ekraffmiller ekraffmiller self-assigned this Oct 30, 2023
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a comment about the DatasetLockReason values.

src/datasets/domain/models/DatasetLock.ts Show resolved Hide resolved
@ekraffmiller ekraffmiller assigned GPortas and unassigned ekraffmiller Oct 31, 2023
@GPortas
Copy link
Contributor Author

GPortas commented Nov 1, 2023

@ekraffmiller We can see the same error that you had yesterday on your localhost, now also in action: https://github.com/IQSS/dataverse-client-javascript/actions/runs/6719463036/job/18261139350

I'm going to link this PR to the issue you created.

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GPortas GPortas self-assigned this Nov 2, 2023
@GPortas GPortas merged commit 1d41e7d into 96-get-dataset-user-permissions Nov 2, 2023
1 of 2 checks passed
@GPortas GPortas deleted the 95-get-dataset-locks branch November 2, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants