Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full codebase redesign #103

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

swillner
Copy link
Collaborator

@swillner swillner commented Dec 3, 2024

  • refactoring of modules
  • remove code duplication
  • separate technical from scientific modelling
  • abstract from statistical modelling library (pymc3)
  • use xarray
  • various smaller changes, e.g. simplified tests

rgieseke and others added 2 commits December 3, 2024 14:28
- refactoring of modules
- remove code duplication
- separate technical from scientific modelling
- abstract from statistical modelling library (pymc3)
- use xarray
- various smaller changes, e.g. simplified tests

Co-authored-by: Sven Willner <[email protected]>
Co-authored-by: Robert Gieseke <[email protected]>
@rgieseke
Copy link
Collaborator

rgieseke commented Dec 3, 2024

After a previous PR (#101) had a tiny bug we've made sure to re-run the full test suite to ensure all variables are having the same results as initially.

=== test session starts ===
platform linux -- Python 3.11.10, pytest-8.3.4, pluggy-1.5.0
rootdir: /home/robert/Projects/attrici/attrici-private
configfile: pyproject.toml
plugins: anyio-4.6.2.post1
collected 42 items                                                                                                                                                                                                                   

tests/test_detrend.py .........                                                                                                                                                                                                [ 21%]
tests/test_preprocessing.py ..                                                                                                                                                                                                 [ 26%]
tests/test_vendored_ssa.py ..............................                                                                                                                                                                      [ 97%]
tests/test_version.py .        
==== 42 passed ===

swillner and others added 2 commits December 4, 2024 12:25
pm.Deterministic("logp") must be defined *after* deterministic
paramter definition but *before* distribution definition.
@rgieseke
Copy link
Collaborator

rgieseke commented Dec 4, 2024

We've found a tiny bug for logp reporting and fixed it with two additional commits. Note that for the variables pr and tasrange the values in reference data are different due to the tiny bug fixed in #101 so these two are skipped (values are in the same range though).

@matthiasmengel
Copy link
Member

Great progress, thanks!

@matthiasmengel matthiasmengel merged commit 2365ddd into ISI-MIP:develop Dec 12, 2024
1 check passed
@rgieseke rgieseke deleted the codebase_redesign branch December 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants