Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDTensors] DiagonalArray tensor operations #1226

Merged
merged 43 commits into from
Nov 1, 2023
Merged

[NDTensors] DiagonalArray tensor operations #1226

merged 43 commits into from
Nov 1, 2023

Conversation

mtfishman
Copy link
Member

Description

Building off of #1225, this is work in progress defining tensor operations for DiagonalArray, with the goal of making them usable as ITensor storage backends for DMRG.

mtfishman and others added 26 commits October 27, 2023 09:06
@mtfishman
[NDTensors] Add more operations for Array storage
9b7f469
@mtfishman
Get more Array storage functionality working
cbd0307
@mtfishman
Format
2a6b8da
@mtfishman
New similar definition
460082d
@mtfishman
Merge branch 'main' into NDTensors_arraytensor_ops
821dbdf
@mtfishman
Define contraction of ArrayStorage with Diag
ffe3f66
@mtfishman @github-actions
Format
9c571bc 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mtfishman @github-actions
Format
cc3136c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mtfishman
Reorganize Combiner code
74d722d
@mtfishman
Merge branch 'NDTensors_arraytensor_ops' of github.com:ITensor/ITenso…
ed772e1 
…rs.jl into NDTensors_arraytensor_ops
@mtfishman
Get eigen working with Array storage
a40e4a3
@mtfishman
Improve eigen code a bit
7c0509b
@mtfishman @github-actions
Format
6febc37 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mtfishman
Fix tests
2208569
@mtfishman
Merge branch 'NDTensors_arraytensor_ops' of github.com:ITensor/ITenso…
25814f6 
…rs.jl into NDTensors_arraytensor_ops
@mtfishman @github-actions
Format
45e8b87 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mtfishman @github-actions
Format
2801f7a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mtfishman
Fix tests
a07f808
@mtfishman
Merge branch 'NDTensors_arraytensor_ops' of github.com:ITensor/ITenso…
c14150c 
…rs.jl into NDTensors_arraytensor_ops
@mtfishman
[NDTensors] Add DiagonalArrays submodule
62339ba
@mtfishman
Add tests
9d4d7eb
@mtfishman
Format
b537e6a
@mtfishman
Load Compat for allequal
ba24b1c
@mtfishman
Merge branch 'main' into NDTensors_diagonalarray
9c457d9
@mtfishman
[NDTensors] DiagonalArray tensor operations
e865d27
@mtfishman
Merge main
d59fcfb
@mtfishman mtfishman marked this pull request as draft October 31, 2023 00:34
github-actions[bot]
github-actions bot reviewed Oct 31, 2023
View reviewed changes
NDTensors/src/DiagonalArrays/examples/README.jl Outdated Show resolved Hide resolved
NDTensors/src/arraystorage/arraystorage/storage/contract.jl Outdated Show resolved Hide resolved
NDTensors/src/arraystorage/diagonalarray/storage/contract.jl Outdated Show resolved Hide resolved
NDTensors/test/arraytensor/diagonalarray.jl Outdated Show resolved Hide resolved
NDTensors/test/arraytensor/diagonalarray.jl Outdated Show resolved Hide resolved
@mtfishman
Copy link
Member Author

[test ITensors mps]

@mtfishman mtfishman marked this pull request as ready for review November 1, 2023 03:17
@mtfishman mtfishman changed the title [WIP][NDTensors] DiagonalArray tensor operations [NDTensors] DiagonalArray tensor operations Nov 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/6715162746

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/6715162746

@mtfishman
Copy link
Member Author

@kmp5VT @emstoudenmire in the latest, I have DMRG working entirely without Dense or Diag, i.e. just using Array and DiagonalArray as storage.

I also did some code refactoring, like improving the keyword argument logic (listing them explicitly, avoiding get) and also refactored the svd code for Tensors with Array storage, which I think is much nicer and simpler now.

@kmp5VT mostly this changed code in the arraystorage folder but I made some changes in other parts of the code as well, hopefully it doesn't cause too many conflicts with PRs you are working on.

@mtfishman mtfishman merged commit 70967cd into main Nov 1, 2023
7 checks passed
@mtfishman mtfishman deleted the NDTensors_diagonalarray_ops branch November 1, 2023 12:20
This was referenced Nov 1, 2023
Merged
Closed
Merged
Closed
@mtfishman mtfishman mentioned this pull request Nov 21, 2023
Merged
8 tasks
@brian-dellabetta brian-dellabetta mentioned this pull request Jan 3, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtfishman @codecov-commenter