Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors][Bug] Fix CPU performance issue #1218

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

kmp5VT
Copy link
Collaborator

@kmp5VT kmp5VT commented Oct 25, 2023

Description

Joey found that contractions slowed down by roughly a factor of 5-10. It turned out that a permutedim was being evaluated lazily resulting in a complicated type that wasn't being parsed properly and as a result generic mul! was begin called. Here I create a function to unwrap a strided array to properly show its parenttype and I force evaluate of a permutation to ensure the strided version of mul is called.

Checklist:

  • Fix Joeys CPU mul! slowdown

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (871e59d) 83.63% compared to head (aecad59) 67.47%.
Report is 1 commits behind head on main.

❗ Current head aecad59 differs from pull request most recent head 0e52496. Consider uploading reports for the commit 0e52496 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1218       +/-   ##
===========================================
- Coverage   83.63%   67.47%   -16.16%     
===========================================
  Files          89       88        -1     
  Lines        8445     8397       -48     
===========================================
- Hits         7063     5666     -1397     
- Misses       1382     2731     +1349     

see 55 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman merged commit bde7da7 into ITensor:main Oct 25, 2023
7 checks passed
@kmp5VT kmp5VT deleted the kmp5/debug/fix_cpu_bug branch October 25, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants