[NDTensors][Bug] Fix CPU performance issue #1218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Joey found that contractions slowed down by roughly a factor of 5-10. It turned out that a permutedim was being evaluated lazily resulting in a complicated type that wasn't being parsed properly and as a result generic
mul!
was begin called. Here I create a function to unwrap a strided array to properly show its parenttype and I force evaluate of a permutation to ensure the strided version of mul is called.Checklist:
mul!
slowdown