chore(edits): UMA Extension Edits #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pblivin0x
changed the base branch from
master
to
ckoopmann/optimistic-auction-rebalance-extension
ckoopmann
force-pushed
the
pblivin0x/uma-extension-edits
branch
from
c0e2d82 to
0aaf4a8
Compare
ckoopmann
reviewed
Jan 4, 2024
| @@ -412,7 +414,7 @@ if (process.env.INTEGRATIONTEST) { | |||
| { | |||
| collateral: collateralAssetAddress, | |||
| liveness, | |||
| bondAmount: BigNumber.from(0), | |||
There was a problem hiding this comment.
@pblivin0x Normally this should work with 0 bondAmount as well as we are comparing it against the minimumBond as returned by the oracle for a given collateral token.
However it seems that the oracle returns a minimum bond of "0" for INDEX which we should raise / double check with the UMA team.
See:
ckoopmann
merged commit 83356e6
into
ckoopmann/optimistic-auction-rebalance-extension
7 checks passed
pblivin0x
added a commit
that referenced
this pull request
Jan 9, 2024
* Initialize OptimisticAuctionRebalance module from Global version and fix compilation issues * Add AssetAllowList to BaseOptimisticRebalanceExtension * Use extisting AuctionRebalanceExtension * Only allowed assets as new components * Port tests from global version * smol fix * PR Feedback round 2 * PR Feedback round 3 * Simplify constructor tests * Copy unit tests and run integrated with existing dseth deployment * Test failing with unsupported identifier error * All tests passing against uma deployed oracle * Set block number individually in test * Add isOpen boolean gate * Set isOpen to false after starting rebalance * Add onlyIfOpen modifier to startRebalance function * Refactor / extend integration tests * Disable locking set token * Adjust tests * Add V1 suffix * Remove shouldLockSetToken argument entirely from propose method * Add events for updating the isOpen parameter * chore(edits): UMA Extension Edits (#157) * Add events for updating the isOpen parameter * lintoor * remove .only() * lintoor * fix AssetAllowList nits * Run only new integration tests * Fix unittests * Add tests for require statements in proposeRebalance * Add tests for emitted events * Extend event emission test * Adjust integration test to use index token as proposer collateral (currently failing) * integration test test * cleanups * edit integration tests * Test bond transfer and claim construction * Fix unittest --------- Co-authored-by: ckoopmann <[email protected]> * Add comment with link to optimistic governor reference implementation of _constructClaim * Additional tests arround asset allow list * Additional tests to increase coverage * Declare setToken and auctionModule as immutable * Remove Proposal struct because we are only managing one product per extension * Additional tests to trigger require statements in dispute callback * Fix integration tests * Update contracts/adapters/AuctionRebalanceExtension.sol * integration test cleanups * fix buy auction params * Update contracts/adapters/OptimisticAuctionRebalanceExtensionV1.sol * cleanups * Dummy commit to retrigger CI --------- Co-authored-by: pblivin0x <[email protected]> Co-authored-by: Pranav Bhardwaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
bf2b0b4,9175f17.only()a5c4f4cd121d01proposeRebalance()unit tests