Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(edits): UMA Extension Edits #157

Merged
merged 16 commits into from
Jan 4, 2024
Merged

chore(edits): UMA Extension Edits #157

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
84672e0
Add events for updating the isOpen parameter
ckoopmann Jan 3, 2024
3ac5f3c
lintoor
ckoopmann Jan 3, 2024
4388dcc
remove .only()
pblivin0x Jan 2, 2024
2ec0295
lintoor
pblivin0x Jan 3, 2024
bda109c
fix AssetAllowList nits
pblivin0x Jan 3, 2024
0aaf4a8
Run only new integration tests
ckoopmann Jan 3, 2024
da33c35
Fix unittests
ckoopmann Jan 3, 2024
c8a8585
Add tests for require statements in proposeRebalance
ckoopmann Jan 3, 2024
4d6113f
Add tests for emitted events
ckoopmann Jan 3, 2024
e5777bf
Extend event emission test
ckoopmann Jan 3, 2024
b843c40
Adjust integration test to use index token as proposer collateral (cu…
ckoopmann Jan 3, 2024
744b3ea
integration test test
pblivin0x Jan 3, 2024
e2d2340
cleanups
pblivin0x Jan 4, 2024
9e2082d
edit integration tests
pblivin0x Jan 4, 2024
49bddfa
Test bond transfer and claim construction
ckoopmann Jan 4, 2024
9d744cc
Fix unittest
ckoopmann Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions test/integration/ethereum/optimisticAuctionRebalanceExtenisonV1.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,10 @@ if (process.env.INTEGRATIONTEST) {
ethers.utils.parseEther("10").toHexString(),
]);
identifierWhitelist = identifierWhitelist.connect(whitelistOwner);
minimumBond = await optimisticOracleV3.getMinimumBond(collateralAssetAddress);
console.log("minimumBond", minimumBond.toString());

// minimumBond = await optimisticOracleV3.getMinimumBond(collateralAssetAddress);
// console.log("minimumBond", minimumBond.toString());
minimumBond = ether(140);

integrationRegistry = IntegrationRegistry__factory.connect(
contractAddresses.setFork.integrationRegistry,
Expand Down Expand Up @@ -178,7 +180,7 @@ if (process.env.INTEGRATIONTEST) {
productSettings = {
collateral: collateralAssetAddress,
liveness,
bondAmount: BigNumber.from(1000),
bondAmount: ether(140),
identifier,
optimisticOracleV3: optimisticOracleV3.address,
};
Expand Down Expand Up @@ -412,7 +414,7 @@ if (process.env.INTEGRATIONTEST) {
{
collateral: collateralAssetAddress,
liveness,
bondAmount: BigNumber.from(0),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pblivin0x Normally this should work with 0 bondAmount as well as we are comparing it against the minimumBond as returned by the oracle for a given collateral token.
However it seems that the oracle returns a minimum bond of "0" for INDEX which we should raise / double check with the UMA team.

See:

index-coop-smart-contracts/contracts/adapters/OptimisticAuctionRebalanceExtensionV1.sol

Line 405 in 9e2082d

function _pullBond(OptimisticRebalanceParams memory optimisticRebalanceParams) internal returns (uint256) {

bondAmount: ether(140),
identifier,
optimisticOracleV3: optimisticOracleV3Mock.address,
},
Expand Down Expand Up @@ -447,7 +449,7 @@ if (process.env.INTEGRATIONTEST) {
{
collateral: collateralAssetAddress,
liveness,
bondAmount: BigNumber.from(0),
bondAmount: ether(140),
identifier,
optimisticOracleV3: optimisticOracleV3Mock.address,
},
Expand Down