-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "[era] transaction view" command fail and advice to use "debug transaction view" instead #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/unplug-era-transaction-view
branch
from
August 6, 2024 09:39
f8d71a7
to
7e03764
Compare
…ransaction view" instead
…tion view" instead
smelc
force-pushed
the
smelc/unplug-era-transaction-view
branch
from
August 6, 2024 09:41
7e03764
to
860c43c
Compare
smelc
requested review from
Jimbo4350,
newhoggy,
carbolymer,
palas,
kevinhammond and
disassembler
as code owners
August 6, 2024 09:41
carbolymer
reviewed
Aug 6, 2024
friendlyTx (viewOutputFormatToFriendlyFormat outputFormat) mOutFile (toCardanoEra era) tx | ||
Cmd.TransactionViewCmdArgs = | ||
liftIO $ do | ||
putStrLn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should go to stderr instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, changed 👍
carbolymer
approved these changes
Aug 6, 2024
@carbolymer> can you have a relook? because writing to stderr changed some golden files |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Contributes to fixing #843
How to trust this PR
cabal run cardano-cli -- conway transaction view
and observe it fails as follows:cabal run cardano-cli -- transaction view
commandChecklist