Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "[era] transaction view" command fail and advice to use "debug transaction view" instead #858

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Aug 6, 2024

Changelog

- description: |
    Make "[era] transaction view" command fail. Please use "debug transaction view" instead.
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Contributes to fixing #843

How to trust this PR

  • Look at the diff of golden files
  • Execute cabal run cardano-cli -- conway transaction view and observe it fails as follows:
→ cabal run cardano-cli -- conway transaction view
Command "era transaction "view" has been removed. Please use "debug transaction view" instead.
→ echo $?
1
  • Observe the same behavior with the legacy cabal run cardano-cli -- transaction view command

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/unplug-era-transaction-view branch from f8d71a7 to 7e03764 Compare August 6, 2024 09:39
@smelc smelc force-pushed the smelc/unplug-era-transaction-view branch from 7e03764 to 860c43c Compare August 6, 2024 09:41
@smelc smelc marked this pull request as ready for review August 6, 2024 09:41
@smelc smelc mentioned this pull request Aug 6, 2024
2 tasks
friendlyTx (viewOutputFormatToFriendlyFormat outputFormat) mOutFile (toCardanoEra era) tx
Cmd.TransactionViewCmdArgs =
liftIO $ do
putStrLn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should go to stderr instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, changed 👍

@smelc
Copy link
Contributor Author

smelc commented Aug 6, 2024

@carbolymer> can you have a relook? because writing to stderr changed some golden files

@smelc smelc added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit afdd769 Aug 7, 2024
23 checks passed
@smelc smelc deleted the smelc/unplug-era-transaction-view branch August 7, 2024 09:19
@smelc smelc mentioned this pull request Aug 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants