Make "[era] transaction view" command fail and advice to use "debug transaction view" instead

cardano-cli/src/Cardano/CLI/EraBased/Commands/Transaction.hs

@@ -248,10 +248,6 @@ newtype TransactionTxIdCmdArgs = TransactionTxIdCmdArgs
   deriving Show
 
 data TransactionViewCmdArgs = TransactionViewCmdArgs
-  { outputFormat :: !ViewOutputFormat
-  , mOutFile :: !(Maybe (File () Out))
-  , inputTxBodyOrTxFile :: !InputTxBodyOrTxFile
-  }
   deriving Show
 
 renderTransactionCmds :: TransactionCmds era -> Text

cardano-cli/src/Cardano/CLI/EraBased/Options/Transaction.hs

@@ -99,8 +99,9 @@ pTransactionCmds era envCli =
             Opt.progDesc "Print a transaction identifier."
     , Just $
         subParser "view" $
-          Opt.info pTransactionView $
-            Opt.progDesc "Print a transaction."
+          Opt.info
+            (pure $ TransactionViewCmd TransactionViewCmdArgs)
+            (Opt.progDesc "This command has been removed. Please use \"debug transaction view\" instead.")
     ]
 
 -- Backwards compatible parsers
@@ -376,11 +377,3 @@ pTransactionId =
   fmap TransactionTxIdCmd $
     TransactionTxIdCmdArgs
       <$> pInputTxOrTxBodyFile
-
-pTransactionView :: Parser (TransactionCmds era)
-pTransactionView =
-  fmap TransactionViewCmd $
-    TransactionViewCmdArgs
-      <$> pTxViewOutputFormat
-      <*> pMaybeOutputFile
-      <*> pInputTxOrTxBodyFile

cardano-cli/src/Cardano/CLI/EraBased/Run/Transaction.hs

@@ -44,8 +44,6 @@ import qualified Cardano.Chain.Common as Byron
 import qualified Cardano.CLI.EraBased.Commands.Transaction as Cmd
 import           Cardano.CLI.EraBased.Run.Genesis.Common (readProtocolParameters)
 import           Cardano.CLI.EraBased.Run.Query
-import           Cardano.CLI.Json.Friendly (friendlyTx, friendlyTxBody,
-                   viewOutputFormatToFriendlyFormat)
 import           Cardano.CLI.Read
 import           Cardano.CLI.Types.Common
 import           Cardano.CLI.Types.Errors.BootstrapWitnessError
@@ -79,6 +77,7 @@ import qualified Data.Text as Text
 import qualified Data.Text.IO as Text
 import           Data.Type.Equality (TestEquality (..))
 import           Lens.Micro ((^.))
+import qualified System.Exit as IO
 import qualified System.IO as IO
 
 runTransactionCmds :: Cmd.TransactionCmds era -> ExceptT TxCmdError IO ()
@@ -1698,30 +1697,11 @@ runTransactionViewCmd
   => Cmd.TransactionViewCmdArgs
   -> ExceptT TxCmdError IO ()
 runTransactionViewCmd
-  Cmd.TransactionViewCmdArgs
-    { outputFormat
-    , mOutFile
-    , inputTxBodyOrTxFile
-    } =
-    case inputTxBodyOrTxFile of
-      InputTxBodyFile (File txbodyFilePath) -> do
-        txbodyFile <- liftIO $ fileOrPipe txbodyFilePath
-        unwitnessed <-
-          firstExceptT TxCmdTextEnvCddlError . newExceptT $
-            readFileTxBody txbodyFile
-        InAnyShelleyBasedEra era txbody <- pure $ unIncompleteCddlTxBody unwitnessed
-        -- Why are we differentiating between a transaction body and a transaction?
-        -- In the case of a transaction body, we /could/ simply call @makeSignedTransaction []@
-        -- to get a transaction which would allow us to reuse friendlyTxBS. However,
-        -- this would mean that we'd have an empty list of witnesses mentioned in the output, which
-        -- is arguably not part of the transaction body.
-        firstExceptT TxCmdWriteFileError . newExceptT $
-          friendlyTxBody (viewOutputFormatToFriendlyFormat outputFormat) mOutFile (toCardanoEra era) txbody
-      InputTxFile (File txFilePath) -> do
-        txFile <- liftIO $ fileOrPipe txFilePath
-        InAnyShelleyBasedEra era tx <- lift (readFileTx txFile) & onLeft (left . TxCmdTextEnvCddlError)
-        firstExceptT TxCmdWriteFileError . newExceptT $
-          friendlyTx (viewOutputFormatToFriendlyFormat outputFormat) mOutFile (toCardanoEra era) tx
+  Cmd.TransactionViewCmdArgs =
+    liftIO $ do
+      putStrLn
+        "Command \"era transaction view\" has been removed. Please use \"debug transaction view\" instead."
+      IO.exitWith (IO.ExitFailure 1)
 
 -- ----------------------------------------------------------------------------
 -- Witness commands

cardano-cli/src/Cardano/CLI/Legacy/Commands/Transaction.hs

@@ -135,9 +135,6 @@ data LegacyTransactionCmds
   | TransactionTxIdCmd
       InputTxBodyOrTxFile
   | TransactionViewCmd
-      ViewOutputFormat
-      (Maybe (File () Out))
-      InputTxBodyOrTxFile
 
 renderLegacyTransactionCmds :: LegacyTransactionCmds -> Text
 renderLegacyTransactionCmds = \case

cardano-cli/src/Cardano/CLI/Legacy/Options.hs

@@ -300,7 +300,7 @@ pTransaction envCli =
         (Opt.info pTransactionId $ Opt.progDesc "Print a transaction identifier.")
     , subParser "view" $
         Opt.info pTransactionView $
-          Opt.progDesc "Print a transaction."
+          Opt.progDesc "This command has been removed. Please use \"debug transaction view\" instead."
     ]
  where
   -- Backwards compatible parsers
@@ -488,10 +488,7 @@ pTransaction envCli =
 
   pTransactionView :: Parser LegacyTransactionCmds
   pTransactionView =
-    TransactionViewCmd
-      <$> pTxViewOutputFormat
-      <*> pMaybeOutputFile
-      <*> pInputTxOrTxBodyFile
+    pure TransactionViewCmd
 
 pNodeCmds :: Parser LegacyNodeCmds
 pNodeCmds =

cardano-cli/src/Cardano/CLI/Legacy/Run/Transaction.hs

@@ -152,8 +152,8 @@ runLegacyTransactionCmds = \case
     runLegacyTransactionHashScriptDataCmd scriptDataOrFile
   TransactionTxIdCmd txinfile ->
     runLegacyTransactionTxIdCmd txinfile
-  TransactionViewCmd yamlOrJson mOutFile txinfile ->
-    runLegacyTransactionViewCmd yamlOrJson mOutFile txinfile
+  TransactionViewCmd ->
+    runLegacyTransactionViewCmd
   TransactionPolicyIdCmd sFile ->
     runLegacyTransactionPolicyIdCmd sFile
   TransactionWitnessCmd txBodyfile witSignData mbNw outFile ->
@@ -508,18 +508,10 @@ runLegacyTransactionTxIdCmd txfile =
         txfile
     )
 
-runLegacyTransactionViewCmd
-  :: ViewOutputFormat -> Maybe (File () Out) -> InputTxBodyOrTxFile -> ExceptT TxCmdError IO ()
-runLegacyTransactionViewCmd
-  yamlOrJson
-  mOutFile
-  inputTxBodyOrTxFile =
-    runTransactionViewCmd
-      ( Cmd.TransactionViewCmdArgs
-          yamlOrJson
-          mOutFile
-          inputTxBodyOrTxFile
-      )
+runLegacyTransactionViewCmd :: ExceptT TxCmdError IO ()
+runLegacyTransactionViewCmd =
+  runTransactionViewCmd
+    Cmd.TransactionViewCmdArgs
 
 runLegacyTransactionWitnessCmd
   :: ()

cardano-cli/test/cardano-cli-golden/files/golden/help.cli

@@ -1206,13 +1206,9 @@ Usage: cardano-cli shelley transaction txid
 
   Print a transaction identifier.
 
-Usage: cardano-cli shelley transaction view [--output-json | --output-yaml]
-                                              [--out-file FILE]
-                                              ( --tx-body-file FILE
-                                              | --tx-file FILE
-                                              )
+Usage: cardano-cli shelley transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli allegra 
                              ( address
@@ -2405,13 +2401,9 @@ Usage: cardano-cli allegra transaction txid
 
   Print a transaction identifier.
 
-Usage: cardano-cli allegra transaction view [--output-json | --output-yaml]
-                                              [--out-file FILE]
-                                              ( --tx-body-file FILE
-                                              | --tx-file FILE
-                                              )
+Usage: cardano-cli allegra transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli mary 
                           ( address
@@ -3718,13 +3710,9 @@ Usage: cardano-cli mary transaction txid (--tx-body-file FILE | --tx-file FILE)
 
   Print a transaction identifier.
 
-Usage: cardano-cli mary transaction view [--output-json | --output-yaml]
-                                           [--out-file FILE]
-                                           ( --tx-body-file FILE
-                                           | --tx-file FILE
-                                           )
+Usage: cardano-cli mary transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli alonzo 
                             ( address
@@ -5054,13 +5042,9 @@ Usage: cardano-cli alonzo transaction txid
 
   Print a transaction identifier.
 
-Usage: cardano-cli alonzo transaction view [--output-json | --output-yaml]
-                                             [--out-file FILE]
-                                             ( --tx-body-file FILE
-                                             | --tx-file FILE
-                                             )
+Usage: cardano-cli alonzo transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli babbage 
                              ( address
@@ -6412,13 +6396,9 @@ Usage: cardano-cli babbage transaction txid
 
   Print a transaction identifier.
 
-Usage: cardano-cli babbage transaction view [--output-json | --output-yaml]
-                                              [--out-file FILE]
-                                              ( --tx-body-file FILE
-                                              | --tx-file FILE
-                                              )
+Usage: cardano-cli babbage transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli conway 
                             ( address
@@ -8301,13 +8281,9 @@ Usage: cardano-cli conway transaction txid
 
   Print a transaction identifier.
 
-Usage: cardano-cli conway transaction view [--output-json | --output-yaml]
-                                             [--out-file FILE]
-                                             ( --tx-body-file FILE
-                                             | --tx-file FILE
-                                             )
+Usage: cardano-cli conway transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli latest 
                             ( address
@@ -9656,13 +9632,9 @@ Usage: cardano-cli latest transaction txid
 
   Print a transaction identifier.
 
-Usage: cardano-cli latest transaction view [--output-json | --output-yaml]
-                                             [--out-file FILE]
-                                             ( --tx-body-file FILE
-                                             | --tx-file FILE
-                                             )
+Usage: cardano-cli latest transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli legacy Legacy commands
 
@@ -10755,13 +10727,9 @@ Usage: cardano-cli legacy transaction txid
 
   Print a transaction identifier.
 
-Usage: cardano-cli legacy transaction view [--output-json | --output-yaml]
-                                             [--out-file FILE]
-                                             ( --tx-body-file FILE
-                                             | --tx-file FILE
-                                             )
+Usage: cardano-cli legacy transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli legacy key 
                                 ( verification-key
@@ -12016,11 +11984,9 @@ Usage: cardano-cli transaction txid (--tx-body-file FILE | --tx-file FILE)
 
   Print a transaction identifier.
 
-Usage: cardano-cli transaction view [--output-json | --output-yaml]
-                                      [--out-file FILE]
-                                      (--tx-body-file FILE | --tx-file FILE)
+Usage: cardano-cli transaction view 
 
-  Print a transaction.
+  This command has been removed. Please use "debug transaction view" instead.
 
 Usage: cardano-cli key 
                          ( verification-key

cardano-cli/test/cardano-cli-golden/files/golden/help/allegra_transaction.cli

@@ -40,4 +40,5 @@ Available commands:
                            output.
   hash-script-data         Calculate the hash of script data.
   txid                     Print a transaction identifier.
-  view                     Print a transaction.
+  view                     This command has been removed. Please use "debug
+                           transaction view" instead.

cardano-cli/test/cardano-cli-golden/files/golden/help/allegra_transaction_view.cli

@@ -1,16 +0,0 @@
-Usage: cardano-cli allegra transaction view [--output-json | --output-yaml]
-                                              [--out-file FILE]
-                                              ( --tx-body-file FILE
-                                              | --tx-file FILE
-                                              )
-
-  Print a transaction.
-
-Available options:
-  --output-json            Format transaction view output to JSON.
-  --output-yaml            Format transaction view output to YAML. Defaults to
-                           JSON if unspecified.
-  --out-file FILE          Optional output file. Default is to write to stdout.
-  --tx-body-file FILE      Input filepath of the JSON TxBody.
-  --tx-file FILE           Input filepath of the JSON Tx.
-  -h,--help                Show this help text

cardano-cli/test/cardano-cli-golden/files/golden/help/alonzo_transaction.cli

@@ -44,4 +44,5 @@ Available commands:
                            output.
   hash-script-data         Calculate the hash of script data.
   txid                     Print a transaction identifier.
-  view                     Print a transaction.
+  view                     This command has been removed. Please use "debug
+                           transaction view" instead.

cardano-cli/test/cardano-cli-golden/files/golden/help/alonzo_transaction_view.cli

@@ -1,16 +0,0 @@
-Usage: cardano-cli alonzo transaction view [--output-json | --output-yaml]
-                                             [--out-file FILE]
-                                             ( --tx-body-file FILE
-                                             | --tx-file FILE
-                                             )
-
-  Print a transaction.
-
-Available options:
-  --output-json            Format transaction view output to JSON.
-  --output-yaml            Format transaction view output to YAML. Defaults to
-                           JSON if unspecified.
-  --out-file FILE          Optional output file. Default is to write to stdout.
-  --tx-body-file FILE      Input filepath of the JSON TxBody.
-  --tx-file FILE           Input filepath of the JSON Tx.
-  -h,--help                Show this help text

cardano-cli/test/cardano-cli-golden/files/golden/help/babbage_transaction.cli

@@ -44,4 +44,5 @@ Available commands:
                            output.
   hash-script-data         Calculate the hash of script data.
   txid                     Print a transaction identifier.
-  view                     Print a transaction.
+  view                     This command has been removed. Please use "debug
+                           transaction view" instead.

cardano-cli/test/cardano-cli-golden/files/golden/help/babbage_transaction_view.cli

@@ -1,16 +0,0 @@
-Usage: cardano-cli babbage transaction view [--output-json | --output-yaml]
-                                              [--out-file FILE]
-                                              ( --tx-body-file FILE
-                                              | --tx-file FILE
-                                              )
-
-  Print a transaction.
-
-Available options:
-  --output-json            Format transaction view output to JSON.
-  --output-yaml            Format transaction view output to YAML. Defaults to
-                           JSON if unspecified.
-  --out-file FILE          Optional output file. Default is to write to stdout.
-  --tx-body-file FILE      Input filepath of the JSON TxBody.
-  --tx-file FILE           Input filepath of the JSON Tx.
-  -h,--help                Show this help text

cardano-cli/test/cardano-cli-golden/files/golden/help/conway_transaction.cli

@@ -44,4 +44,5 @@ Available commands:
                            output.
   hash-script-data         Calculate the hash of script data.
   txid                     Print a transaction identifier.
-  view                     Print a transaction.
+  view                     This command has been removed. Please use "debug
+                           transaction view" instead.

cardano-cli/test/cardano-cli-golden/files/golden/help/conway_transaction_view.cli

@@ -1,16 +0,0 @@
-Usage: cardano-cli conway transaction view [--output-json | --output-yaml]
-                                             [--out-file FILE]
-                                             ( --tx-body-file FILE
-                                             | --tx-file FILE
-                                             )
-
-  Print a transaction.
-
-Available options:
-  --output-json            Format transaction view output to JSON.
-  --output-yaml            Format transaction view output to YAML. Defaults to
-                           JSON if unspecified.
-  --out-file FILE          Optional output file. Default is to write to stdout.
-  --tx-body-file FILE      Input filepath of the JSON TxBody.
-  --tx-file FILE           Input filepath of the JSON Tx.
-  -h,--help                Show this help text

cardano-cli/test/cardano-cli-golden/files/golden/help/latest_transaction.cli

@@ -44,4 +44,5 @@ Available commands:
                            output.
   hash-script-data         Calculate the hash of script data.
   txid                     Print a transaction identifier.
-  view                     Print a transaction.
+  view                     This command has been removed. Please use "debug
+                           transaction view" instead.